[Home]

Summary:ASTERISK-05389: Zaptel-1.0.9.2 channel drivers do not include <asm/io.h> on Alpha.
Reporter:khmann (khmann)Labels:
Date Opened:2005-10-28 15:28:11Date Closed:2011-06-07 14:10:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:compiling Zaptel on Alpha under current Debian 3.1 (Sarge) fails with the following and then some:

wcfxo.c: In function `wcfxo_interrupt':
wcfxo.c:412: warning: implicit declaration of function `inb'
wcfxo.c:413: warning: implicit declaration of function `outb'
wcfxo.c: In function `wcfxo_hardware_init':
wcfxo.c:693: warning: implicit declaration of function `outl'

wcfxs.c: In function `__write_8bits':
wcfxs.c:487: warning: implicit declaration of function `outb'
wcfxs.c: In function `__read_8bits':
wcfxs.c:549: warning: implicit declaration of function `inb'
wcfxs.c: In function `wcfxs_hardware_init':
wcfxs.c:1903: warning: implicit declaration of function `outl'

this is gcc 3.3.5 libc6.1 (2.3.2.ds1-22).

placing an #include <asm/io.h> at the top of wcfxo.c, wcfxs.c, (and presumably all other PCI drivers) fixes this and produces working zaptel.
Comments:By: khmann (khmann) 2005-10-28 15:33:51

I should probably also add:

vanilla linux-2.4.31 from kernel.org.
/usr/src/linux-2.4 symlink is correct
/usr/include/linux is (correctly) symlink'd to /usr/src/linux/include/linux, though this has no effect either way.

if anybody cares, I am more than happy to provide ssh access.  I apologize in advance if this turns out to be some kind of "linux distribution" problem.
By: Mark Spencer (markster) 2005-10-29 14:45:16

Fixed in CVS head.
By: khmann (khmann) 2005-10-31 10:45:03.000-0600

confirmed that today's cvs zaptel (not -r v1-0) seems to be fixed.  thankyou!
By: Russell Bryant (russell) 2005-10-31 14:02:07.000-0600

fixed in 1.0 as well
By: Digium Subversion (svnbot) 2008-06-07 11:07:30

Repository: dahdi
Revision: 800

U   trunk/wcfxo.c
U   trunk/wctdm.c

------------------------------------------------------------------------
r800 | markster | 2008-06-07 11:07:27 -0500 (Sat, 07 Jun 2008) | 2 lines

Add missing io include (bug ASTERISK-5389)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=800
By: Digium Subversion (svnbot) 2008-06-07 11:07:43

Repository: dahdi
Revision: 801

U   branches/v1-0/wcfxo.c
U   branches/v1-0/wcfxs.c

------------------------------------------------------------------------
r801 | russell | 2008-06-07 11:07:41 -0500 (Sat, 07 Jun 2008) | 2 lines

add missing include (issue ASTERISK-5389)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=801