Summary:ASTERISK-05386: [patch] some little comment clarifications, and improve debug logging
Reporter:Steve Davies . (stevedavies)Labels:
Date Opened:2005-10-28 13:40:29Date Closed:2008-01-15 15:52:58.000-0600
Versions:Frequency of
Environment:Attachments:( 0) asterisk-iax2fixes-commentsandlogging.patch
Description:I've been working on iax2 registration efficiency.

The result is a few patches to offer.  This is the first, which is simply:

- some slight clarifications to comments in the code
- some improvements to existing ast_log messages to provide a bit more detail
- a couple of new log messages:
     when we expire a peer registration
     some warning debugs when the network_thread is getting bogged down

There's three "SLD" notes to myself - the result of tracing through a registration to find all the find_peer calls.  I'll get rid of them once I've finished the optimisation.

I'll follow up with a couple of others patches in the next day or two.



disclaimer in file.
(do you really need to know that seeing its a question in the submission form?)
Comments:By: Mark Spencer (markster) 2005-10-29 15:02:49

Warnings seem more appropriate for actual warning conditions, not things we would expect to see in real life.

By: Steve Davies . (stevedavies) 2005-10-30 08:58:25.000-0600


Are you referring to the LOG_WARNING when a registration expires?

Or to the messages in the thread main loop where we have lots of events happening at once.

If the second - I don't think it IS normal for more than 20 tasks to have got overdue between calls - on my system those warning mesasges do provide an early warning to look into what is running slow.

Anyway - happy to rework the patch, but choose one or more of the following:

a) change expiring registration from LOG_WARNING to NOTICE or something
b) Drop the extra messages in the main loop
c) Leave the extra messages in, but make them DEBUG
d) change the 20 task threshold to something more.


By: Kevin P. Fleming (kpfleming) 2005-10-31 17:09:51.000-0600

Committed to CVS HEAD, but I changed the 'expiring' message to LOG_DEBUG, otherwise we'll get spammed with 'bug' reports about people seeing it. Thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:52:58.000-0600

Repository: asterisk
Revision: 6906

U   trunk/channels/chan_iax2.c

r6906 | kpfleming | 2008-01-15 15:52:58 -0600 (Tue, 15 Jan 2008) | 2 lines

add some additional log output and comment cleanup in the registration process (issue ASTERISK-5386)