Summary:	ASTERISK-05380: [patch] [post 1.2] Preparation for adding support for different sorts of tests into app_test
Reporter:	Steve Davies . (stevedavies)	Labels:
Date Opened:	2005-10-28 04:11:15	Date Closed:	2011-06-07 14:02:58
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_test
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-multitest.patch
Description:	app_test provides a very nice "basic communications" test that can be used between two Asterisk servers. This patch does the groundwork for extending app_test to allow other tests to be supported. As you'd expect, the actual testing steps are extracted out of testclient_exec and textserver_exec and moved to separate functions.  A backwards-compatible tweak to the initial handshake allows the requested test-number to be passed and acknowledged. I add a testnumber as a 2nd parameter to TestClient.  If its not included, we do test "1" which is the existing test. The implementation is backward compatible with the existing app_test when test 1, the default, is requested.  So a client using this extensible code can still test against the old server and vice versa. I have written stubs for the new test that I have in mind, but implementation is still to follow. Regards, Steve
Comments:	By: Russell Bryant (russell) 2005-12-20 00:54:32.000-0600 initial code comments ... 1) Use ast_copy_string instead of strncpy 2) In the application description, please note that the 2nd test is not yet implemented By: Steve Davies . (stevedavies) 2005-12-29 21:32:29.000-0600 Thanks for the feedback. Still want to progress this - perhaps over the weekend. Steve By: Matt O'Gorman (mogorman) 2006-01-11 18:02:19.000-0600 hey steve how have your weekends been ^_^ are you still working on this or can it be cloesed till you get more time. By: Steve Davies . (stevedavies) 2006-01-17 22:43:45.000-0600 Up to you guys; if you want close it and I'll put it up again when there actually are some new tests. Steve By: Russell Bryant (russell) 2006-01-18 07:09:48.000-0600 I think this is fine to merge without any new tests.  It is still an improvement to the structure of the application.  I would like someone to test it to make sure it still works as expected, though. By: Steve Davies . (stevedavies) 2006-01-18 09:06:22.000-0600 OK - I'll clean up the strncpyies and make against svn trunk and upload a fresh patch. Steve By: Tilghman Lesher (tilghman) 2006-03-01 15:50:42.000-0600 Any update? By: Russell Bryant (russell) 2006-05-03 13:47:50 I'm suspending this for now due to the lack of updates.  Please re-open this issue if you decide to pick this project up again.  Thanks!