Summary:ASTERISK-05367: [patch] [post 1.2] Cannot track device state of MGCP channels
Reporter:gkloepfer (gkloepfer)Labels:
Date Opened:2005-10-25 16:56:38Date Closed:2006-01-20 22:16:11.000-0600
Versions:Frequency of
Environment:Attachments:( 0) chan_mgcp.c.diff.1026
( 1) chan_mgcp.diff
Description:Cannot track the device state of MGCP devices using hint mechanism
because the devicestate callback was not defined for MGCP.  Patch
attached implements the devicestate callback for MGCP.
Comments:By: Olle Johansson (oej) 2005-10-26 01:09:26

Thank you for contributing to Asterisk!

BTW, if you have time, could you please take a moment and add some explanatory doxygen comments to chan_mgcp, like we have in chan_sip? It needs a bit of documentation.

By: gkloepfer (gkloepfer) 2005-10-26 05:39:46

Will add the dox and have a new patch by the end of the day today.

By: gkloepfer (gkloepfer) 2005-10-26 14:09:15

updated diff chan_mgcp.c.diff.1026 added that is diff'd against
the 26-Oct-2005 -HEAD along with some doxygen tags added.

My code is formatted according to the coding guidelines, but
the remainder of chan_mgcp.c isn't.  I tried to get some
tags where I could add some, but chan_mgcp.c really needs some
review by the folks who wrote it (I can't tell if the two-letter
abbreviations all over the code has specific meaning, or if it's
the initials of the people modifying the code, which would be
contrary to the coding standards).

In any case, my contribution does have the tags documenting the
parameters and return values.

It has also been pretty well tested by this point and appears to
function OK.

By: philipp2 (philipp2) 2005-11-20 19:55:18.000-0600

Works fine here so far on 1.2.0

By: philipp2 (philipp2) 2005-12-09 12:32:08.000-0600

What is keeping this from going into SVN, or even into 1.2.2? This is not exactly a new feature, it rather completes the hint support.

By: Olle Johansson (oej) 2006-01-04 12:18:49.000-0600

I recommend this for svn trunk.

By: Tilghman Lesher (tilghman) 2006-01-20 22:16:11.000-0600

Committed to trunk.