| Summary: | ASTERISK-05361: [patch] Fix up AgentCallbackLogin arguments | ||
| Reporter: | Russell Bryant (russell) | Labels: | |
| Date Opened: | 2005-10-24 21:53:47 | Date Closed: | 2005-10-26 12:23:29 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_agent |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) callback.patch | |
| Description: | I noticed that AgentCallbackLogin was doing some nasty things with its arguments. 1) It assumed an extension is always numeric. 2) I had to change the syntax slightly so that the options string can not be confused with an extension being specified. I considered putting the options at the end, but decided to do it this way to be consistent with AgentLogin. 3) As a bonus, I included a little bit of cleanup to LOCAL_USER handling to make sure REMOVE was the last thing done before returning. I couldn't help myself. ****** ADDITIONAL INFORMATION ****** If this is ok, I'll a note to UPGRADE.txt about the syntax change. | ||
| Comments: | By: Russell Bryant (russell) 2005-10-24 22:10:47 "contexts" should be "context" ... new patch uploaded By: wunderkin (wunderkin) 2005-10-25 00:24:18 Well, it compiles and works at least :) I patched it to 10/15/05 head. Thanks. By: Russell Bryant (russell) 2005-10-26 12:23:19 added to cvs head | ||