ASTERISK-05349: [patch] [post 1.2] Add new channel variable FORWARD_CONTEXT and implement it in app

[Home]

Summary: ASTERISK-05349: [patch] [post 1.2] Add new channel variable FORWARD_CONTEXT and implement it in app_dial.c

Reporter: jerjer (jerjer) Labels:

Date Opened: 2005-10-22 00:46:30 Date Closed: 2006-01-13 12:09:56.000-0600

Priority: Major Regression? No

Status: Closed/Complete Components: Core/General

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) app_dial.c.diff
( 1) README.variables.diff

Description: When channels are forwarded perhaps you want those calls to go into a different context than the current context of the existing channel

****** ADDITIONAL INFORMATION ******

I also moved the other variable directives to the top of the function per guidelines

Comments: By: Olle Johansson (oej) 2005-10-22 04:05:08

Off topic, but still: I think what was meant with that part of the bug guidelines was not to have

 
{ 
statement; 
var declaration; 
statement; 
} 

...in a code block.

So it should be "No variable declarations in the middle of a code block" instead of the current wording that says that it should be at the top of a function... Isn't there an allocation difference between always declaring everything at the top of the function and declaring it only in the block where it is used?

By: Olle Johansson (oej) 2005-10-22 04:09:50

On topic: Can we use the existing transfer_context variable or do we need a new context variable? Just making sure we're gaining new functionality by a third possible context.
By: Olle Johansson (oej) 2005-12-01 21:32:09.000-0600

Did I miss your answer to my question or was it just a too stupid question to answer ?

;-)
By: jerjer (jerjer) 2005-12-04 12:51:23.000-0600

not sure of the answer here. I could possibly see a need to have different context options...then again so says I am sane?
By: jerjer (jerjer) 2005-12-04 12:53:36.000-0600

oej: The difference would be the scope of the variable. I couldn't see any problem with making those couple variable function wide versus only defined within that if statement.
By: Matt O'Gorman (mogorman) 2006-01-13 12:09:30.000-0600

Committed revision 8066. into trunk