[Home]

Summary:ASTERISK-05347: [Patch] vm_newuser incorrectly handles password change
Reporter:Ryan Hulsker (rhulsker)Labels:
Date Opened:2005-10-21 18:42:19Date Closed:2011-06-07 14:10:00
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail.c.patch.txt
Description:If your voicemail password = mailbox, you are directed through the new user setup on first login.

It first asks you to change your password,  if you enter your password wrong the second time, it says "your passwords don't match" followed by "your password has been changed" and sets your password to the first one you entered.

This patch adds the missing while(mailbox == password) which will make you keep trying untll you enter the same one twice.

****** ADDITIONAL INFORMATION ******

My discalmer has been faxed.
Comments:By: Russell Bryant (russell) 2005-10-22 11:41:11

It's hard to see what you actually changed because it looks like you changed a lot of tabs to spaces in your patch.  Please use tabs.
By: Clod Patry (junky) 2005-10-31 20:49:32.000-0600

rhulsker: could you provide a new version for your patch, following drumkilla's advice, please?
By: Russell Bryant (russell) 2005-10-31 21:15:45.000-0600

Ah, I see that you had to change those lines because of your loop.  In any case, that patch could still let an invalid password to be set.  I have committed a different fix.  Thanks for the report.
By: Digium Subversion (svnbot) 2008-01-15 15:53:13.000-0600

Repository: asterisk
Revision: 6922

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r6922 | russell | 2008-01-15 15:53:13 -0600 (Tue, 15 Jan 2008) | 3 lines

when going through new user setup, don't change the password if they don't
match.  Also, allow 3 tries before bailing out.  (issue ASTERISK-5347, different fix)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6922