Summary:ASTERISK-05324: [patch] README.ael update
Reporter:Sergey Okhapkin (sokhapkin)Labels:
Date Opened:2005-10-19 08:30:12Date Closed:2011-06-07 14:10:50
Versions:Frequency of
Environment:Attachments:( 0) README.ael.diff1
Description:The patch adds more information to doc/README.ael
Comments:By: Tilghman Lesher (tilghman) 2005-10-19 09:11:09

"reload <modulename>" is now the preferred way to do reloads, as it works reliably across all modules (which have a reload routine defined).

On your dialplan limitations, note that +101 jumping is deprecated behavior.  You should now use DIALSTATUS to determine how Dial exited.

By: Sergey Okhapkin (sokhapkin) 2005-10-19 09:21:10

You notest seems to me do not fit to AEL-specific README, they should go to something like UPGRATE.txt

By: Tilghman Lesher (tilghman) 2005-10-19 11:05:35

If you're going to mention it as a limitation of AEL (that it has no ability to do n+101), then you need to also mention the preferred method of handling what was previously handled by n+101.

Both notes are in response to changes that you have made in your patchfile.

By: Sergey Okhapkin (sokhapkin) 2005-10-19 12:21:30

Diff updated (can't remove the old one).

By: Olle Johansson (oej) 2005-10-19 12:33:09

Corydon: I think we went back to "module reload" from "reload modulename.so" which is not very user-friendly.
It's good to mention both ways.

By: Tilghman Lesher (tilghman) 2005-10-19 12:36:07

Yes, I agree, it's good to mention both ways.  I haven't seen the other change yet, however.

By: Serge Vecher (serge-v) 2005-10-19 12:38:20

Minor spelling change: "... AEL operators have been" instead of "has been"

By: Tilghman Lesher (tilghman) 2005-10-19 12:41:03

A clarification:  the lack of +101 jumping is not a limitation; it was a conscious design choice.  It doesn't really belong in the limitation section.

By: Sergey Okhapkin (sokhapkin) 2005-10-19 12:56:16

I would call it a limitation, it's a limitation comparing to extensions.conf file syntax. A lot of applications still call +101 extension, try "grep 101 *.c" in apps directory.

By: Tilghman Lesher (tilghman) 2005-10-19 13:08:55

And they will all be changed in due time.  Please either add the note about the preferred method or remove it from the limitations section -- your choice.

By: Olle Johansson (oej) 2005-10-19 13:32:26

We keep the +101 in code for backwards compatibility, but it will be removed in future versions. Readme files should NOT document +101 at this point at all. New users should not use it, nor be recommended to use it or see it as a limitation that new modules does not support it. I fully agree with Corydon76 that this is no limitation of AEL.

Something like "Since AEL is a new addition to Asterisk, it does not support pre-1.2 Asterisk priority jumping methods (+101 return values)."

By: Sergey Okhapkin (sokhapkin) 2005-10-19 14:17:22

Feel free to rephrase the information about +101 jumping method when applying the patch.

The patch already mentiones both "ael reload" and "reload pbx_ael.so" reload methods.

By: Tilghman Lesher (tilghman) 2005-10-19 14:56:05

We don't apply patches.  We make sure that the reporter complies with architectural standards before we recommend that patches be committed.  You're making this process far more difficult than it needs to be.

If you're not willing to make the requested changes, we will close out this patch without committing it.

By: Sergey Okhapkin (sokhapkin) 2005-10-19 17:44:33

I don't know how to reword +101 problem right. Closing the problem will not help users to learn AEL...

By: Tilghman Lesher (tilghman) 2005-10-19 18:10:32

Reopen when you have the wording correct.