| Summary: | ASTERISK-05287: [patch] [post 1.2] use system libgsm where possible | ||
| Reporter: | Tzafrir Cohen (tzafrir) | Labels: | |
| Date Opened: | 2005-10-12 15:47:33 | Date Closed: | 2008-01-15 16:07:59.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/CodecInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) system_libgsm_head.diff ( 1) system_libgsm.dpatch | |
| Description: | The attached patch uses the system copy of libgsm instead of the one accompanioed to the asterisk tarball, if such a copy is availble. Assumptions: * libgsm is installed to a standard system path and no extra -L is needed * Headers are in the subdirectory gsm/ under the system include path. Side effect: * if the local copy is used, adds -I. to CFLAGS in the directory formats. Should be harmless. | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-10-13 16:33:46 This patch does not apply to CVS HEAD, and when I manually applied it, codec_gsm would not build. Please review and see what needs to be changed, thanks! By: Tzafrir Cohen (tzafrir) 2005-10-14 05:30:14 Updated patch for current HEAD. But indeed it still won't work for the local libgsm. It will require a change in the way libgsm is layed in he code or in the includes themselves (like in the zaptel drivers of today?) As for the location: Debian places the files under /usr/include/gsm , /usr/lib . It seems that most other linux linux distros do the same. Anybody actually has it installed under /usr/local somewhere? FreeBSD doesn't have a libgsm package. Gentoo has a package but I could not figure out to where it is installed. By: Russell Bryant (russell) 2005-12-20 01:17:34.000-0600 This has been merged into the trunk with modifications to allow the builtin libgsm to still build correctly. By: Digium Subversion (svnbot) 2008-01-15 16:07:36.000-0600 Repository: asterisk Revision: 7539 U trunk/codecs/Makefile U trunk/codecs/codec_gsm.c ------------------------------------------------------------------------ r7539 | russell | 2008-01-15 16:07:36 -0600 (Tue, 15 Jan 2008) | 2 lines use the system libgsm if available (issue ASTERISK-5287, modified to still work with builtin libgsm) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7539 By: Digium Subversion (svnbot) 2008-01-15 16:07:49.000-0600 Repository: asterisk Revision: 7553 _U team/russell/agent_function/ U team/russell/agent_function/apps/app_chanspy.c U team/russell/agent_function/apps/app_dial.c U team/russell/agent_function/apps/app_directed_pickup.c U team/russell/agent_function/apps/app_meetme.c U team/russell/agent_function/build_tools/make_svn_branch_name U team/russell/agent_function/cdr.c U team/russell/agent_function/channel.c U team/russell/agent_function/channels/Makefile U team/russell/agent_function/channels/chan_iax2.c U team/russell/agent_function/channels/chan_mgcp.c U team/russell/agent_function/channels/chan_sip.c U team/russell/agent_function/codecs/Makefile U team/russell/agent_function/codecs/codec_gsm.c U team/russell/agent_function/doc/README.ael U team/russell/agent_function/file.c U team/russell/agent_function/frame.c U team/russell/agent_function/include/asterisk/channel.h U team/russell/agent_function/include/asterisk/frame.h U team/russell/agent_function/include/asterisk/linkedlists.h U team/russell/agent_function/include/asterisk/rtp.h U team/russell/agent_function/rtp.c ------------------------------------------------------------------------ r7553 | russell | 2008-01-15 16:07:49 -0600 (Tue, 15 Jan 2008) | 129 lines Merged revisions 7509,7511-7512,7514,7516,7518,7520,7522,7524,7528,7538-7542,7547-7548,7551 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7509 | tilghman | 2005-12-16 20:07:44 -0500 (Fri, 16 Dec 2005) | 3 lines Merged revisions 7508 via svnmerge from /branches/1.2 ................ r7511 | kpfleming | 2005-12-16 21:21:36 -0500 (Fri, 16 Dec 2005) | 2 lines block a commit to a module that no longer exists in trunk ................ r7512 | kpfleming | 2005-12-16 21:22:24 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revision 7510 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7510 | kpfleming | 2005-12-16 20:20:04 -0600 (Fri, 16 Dec 2005) | 2 lines fix some buglet when building team branch version strings ........ ................ r7514 | kpfleming | 2005-12-16 22:45:25 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7513 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices) ........ ................ r7516 | kpfleming | 2005-12-16 22:59:27 -0500 (Fri, 16 Dec 2005) | 10 lines Merged revisions 7515 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7515 | kpfleming | 2005-12-16 21:59:05 -0600 (Fri, 16 Dec 2005) | 2 lines Max-Forwards headers must only be present on requests, not responses ........ ................ r7518 | tilghman | 2005-12-17 12:22:24 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7517 via svnmerge from /branches/1.2 ................ r7520 | tilghman | 2005-12-17 13:58:57 -0500 (Sat, 17 Dec 2005) | 3 lines Merged revisions 7519 via svnmerge from /branches/1.2 ................ r7522 | tilghman | 2005-12-19 00:42:55 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7521 via svnmerge from /branches/1.2 ................ r7524 | tilghman | 2005-12-19 14:08:42 -0500 (Mon, 19 Dec 2005) | 3 lines Merged revisions 7523 via svnmerge from /branches/1.2 ................ r7528 | russell | 2005-12-19 18:41:53 -0500 (Mon, 19 Dec 2005) | 4 lines - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ................ r7538 | russell | 2005-12-20 02:45:05 -0500 (Tue, 20 Dec 2005) | 3 lines allow forcing the build to exclude PRI support using WITHOUT_PRI, similar to how we already have WITHOUT_ZAPTEL (issue ASTERISK-5829) ................ r7539 | russell | 2005-12-20 03:16:53 -0500 (Tue, 20 Dec 2005) | 2 lines use the system libgsm if available (issue ASTERISK-5287, modified to still work with builtin libgsm) ................ r7540 | markster | 2005-12-20 04:39:31 -0500 (Tue, 20 Dec 2005) | 2 lines Fix reload of peer contexts (bug ASTERISK-5848) ................ r7541 | markster | 2005-12-20 04:56:55 -0500 (Tue, 20 Dec 2005) | 2 lines Fix segfault on directed pickup when no CDR is available (bug ASTERISK-5839) ................ r7542 | markster | 2005-12-20 05:26:53 -0500 (Tue, 20 Dec 2005) | 2 lines Fix choppy audio with > 20ms audio frames (bug ASTERISK-5548) ................ r7547 | markster | 2005-12-20 08:07:02 -0500 (Tue, 20 Dec 2005) | 3 lines Major peformance improvements to meetme ................ r7548 | markster | 2005-12-20 09:14:01 -0500 (Tue, 20 Dec 2005) | 2 lines Don't bother decode on muted participants ................ r7551 | markster | 2005-12-20 12:52:31 -0500 (Tue, 20 Dec 2005) | 3 lines Major RTP fixes for using inbound SDP on outbound connection, get rid of old local rtp stuff... ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7553 By: Digium Subversion (svnbot) 2008-01-15 16:07:59.000-0600 Repository: asterisk Revision: 7564 _U team/crichter/0.3.0/ U team/crichter/0.3.0/apps/app_chanspy.c U team/crichter/0.3.0/apps/app_dial.c U team/crichter/0.3.0/apps/app_directed_pickup.c U team/crichter/0.3.0/apps/app_meetme.c U team/crichter/0.3.0/build_tools/make_svn_branch_name U team/crichter/0.3.0/cdr.c U team/crichter/0.3.0/channel.c U team/crichter/0.3.0/channels/Makefile U team/crichter/0.3.0/channels/chan_agent.c U team/crichter/0.3.0/channels/chan_iax2.c U team/crichter/0.3.0/channels/chan_mgcp.c U team/crichter/0.3.0/channels/chan_sip.c U team/crichter/0.3.0/cli.c U team/crichter/0.3.0/codecs/Makefile U team/crichter/0.3.0/codecs/codec_gsm.c U team/crichter/0.3.0/doc/README.ael U team/crichter/0.3.0/file.c U team/crichter/0.3.0/frame.c U team/crichter/0.3.0/include/asterisk/channel.h U team/crichter/0.3.0/include/asterisk/frame.h U team/crichter/0.3.0/include/asterisk/linkedlists.h U team/crichter/0.3.0/include/asterisk/rtp.h U team/crichter/0.3.0/include/asterisk/strings.h U team/crichter/0.3.0/res/res_agi.c U team/crichter/0.3.0/rtp.c U team/crichter/0.3.0/utils.c ------------------------------------------------------------------------ r7564 | crichter | 2008-01-15 16:07:58 -0600 (Tue, 15 Jan 2008) | 144 lines Merged revisions 7509,7511-7512,7514,7516,7518,7520,7522,7524,7528,7538-7542,7547-7548,7551,7554,7556 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r7509 | tilghman | 2005-12-17 02:07:44 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7508 via svnmerge from /branches/1.2 ................ r7511 | kpfleming | 2005-12-17 03:21:36 +0100 (Sa, 17 Dez 2005) | 2 lines block a commit to a module that no longer exists in trunk ................ r7512 | kpfleming | 2005-12-17 03:22:24 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revision 7510 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7510 | kpfleming | 2005-12-16 20:20:04 -0600 (Fri, 16 Dec 2005) | 2 lines fix some buglet when building team branch version strings ........ ................ r7514 | kpfleming | 2005-12-17 04:45:25 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revisions 7513 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7513 | kpfleming | 2005-12-16 21:44:30 -0600 (Fri, 16 Dec 2005) | 2 lines forcibly expire previous subscriptions from a peer when they resubscribe (keeps them from building up and waiting for expiration, and stops us sending unwanted NOTIFY messages to devices) ........ ................ r7516 | kpfleming | 2005-12-17 04:59:27 +0100 (Sa, 17 Dez 2005) | 10 lines Merged revisions 7515 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r7515 | kpfleming | 2005-12-16 21:59:05 -0600 (Fri, 16 Dec 2005) | 2 lines Max-Forwards headers must only be present on requests, not responses ........ ................ r7518 | tilghman | 2005-12-17 18:22:24 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7517 via svnmerge from /branches/1.2 ................ r7520 | tilghman | 2005-12-17 19:58:57 +0100 (Sa, 17 Dez 2005) | 3 lines Merged revisions 7519 via svnmerge from /branches/1.2 ................ r7522 | tilghman | 2005-12-19 06:42:55 +0100 (Mo, 19 Dez 2005) | 3 lines Merged revisions 7521 via svnmerge from /branches/1.2 ................ r7524 | tilghman | 2005-12-19 20:08:42 +0100 (Mo, 19 Dez 2005) | 3 lines Merged revisions 7523 via svnmerge from /branches/1.2 ................ r7528 | russell | 2005-12-20 00:41:53 +0100 (Di, 20 Dez 2005) | 4 lines - add note on required values of sip_methods struct - remove duplicate function prototype - remove duplicate ast_mutex_lock (issue ASTERISK-5866) ................ r7538 | russell | 2005-12-20 08:45:05 +0100 (Di, 20 Dez 2005) | 3 lines allow forcing the build to exclude PRI support using WITHOUT_PRI, similar to how we already have WITHOUT_ZAPTEL (issue ASTERISK-5829) ................ r7539 | russell | 2005-12-20 09:16:53 +0100 (Di, 20 Dez 2005) | 2 lines use the system libgsm if available (issue ASTERISK-5287, modified to still work with builtin libgsm) ................ r7540 | markster | 2005-12-20 10:39:31 +0100 (Di, 20 Dez 2005) | 2 lines Fix reload of peer contexts (bug ASTERISK-5848) ................ r7541 | markster | 2005-12-20 10:56:55 +0100 (Di, 20 Dez 2005) | 2 lines Fix segfault on directed pickup when no CDR is available (bug ASTERISK-5839) ................ r7542 | markster | 2005-12-20 11:26:53 +0100 (Di, 20 Dez 2005) | 2 lines Fix choppy audio with > 20ms audio frames (bug ASTERISK-5548) ................ r7547 | markster | 2005-12-20 14:07:02 +0100 (Di, 20 Dez 2005) | 3 lines Major peformance improvements to meetme ................ r7548 | markster | 2005-12-20 15:14:01 +0100 (Di, 20 Dez 2005) | 2 lines Don't bother decode on muted participants ................ r7551 | markster | 2005-12-20 18:52:31 +0100 (Di, 20 Dez 2005) | 3 lines Major RTP fixes for using inbound SDP on outbound connection, get rid of old local rtp stuff... ................ r7554 | russell | 2005-12-20 20:56:52 +0100 (Di, 20 Dez 2005) | 2 lines add AGENT function, similar to SIPPEER or IAXPEER (issue ASTERISK-5383) ................ r7556 | russell | 2005-12-20 21:20:04 +0100 (Di, 20 Dez 2005) | 7 lines - move the string join() function to utils.c since it is used in both cli.c and res_agi.c - reimplement ast_join to be of linear effieciency instead of quadratic - remove some useless checks for "if (e)" - reorder checks for strings starting with '_' to avoid a useless call to ast_join() - check array bounds when parsing arguments to AGI (issue ASTERISK-5715) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=7564 | ||