[Home]

Summary:ASTERISK-05279: [patch] app_directed_pickup -- Picking up active (non-rining) call causes block.
Reporter:Andrew Lindh (andrew)Labels:
Date Opened:2005-10-11 14:20:24Date Closed:2008-01-15 15:50:29.000-0600
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Applications/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) lock-fix.diff
Description:
Using Pickup on a call that is already answered (not rining) will lock that channel and block new calls. The problem is the app "finds" the channel, locks it and then sees that the call is not rining, then exits. It should unlock the call before it exists.

This patch adds the unlock.

There are other feature issues with this app, but this block/lock is real bug.




****** ADDITIONAL INFORMATION ******


From your main asterisk directory:

patch -p0 <lock-fix.diff

It's only a one line fix....disclaimer on file...
Comments:By: Michael Jerris (mikej) 2005-10-11 14:26:50

Josh, check this out.

By: Joshua C. Colp (jcolp) 2005-10-11 15:29:42

I certainly agree with the patch, funny - I had a dream about this and thought I already submitted a fix for it...

By: Mark Spencer (markster) 2005-10-11 17:13:36

Fixed in CVS head, hopefully in a cleaner way.  Thanks for finding this!

By: Digium Subversion (svnbot) 2008-01-15 15:50:29.000-0600

Repository: asterisk
Revision: 6743

U   trunk/apps/app_directed_pickup.c

------------------------------------------------------------------------
r6743 | markster | 2008-01-15 15:50:28 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix directed pickup to a call that is up (bug ASTERISK-5279 with mods)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6743