| Summary: | ASTERISK-05257: [patch]Indentation fixes. | ||
| Reporter: | Jose Pablo Fernandez (pupeno) | Labels: | |
| Date Opened: | 2005-10-06 15:47:06 | Date Closed: | 2008-01-15 15:50:37.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/RTP |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) rtp-indentation.patch ( 1) rtp-indentation-and-documentation.patch ( 2) rtp-indentation-and-documentation2.patch | |
| Description: | The indentation in a part of rtp.c was a horrible mix of tabs and spaces that only worked when tabs were 8 spaces wide (for me, the idea of tabs is to be able to change their size). I corrected it to use all tabs instead of spaces and here's the patch. It also contains other trivial and useless (by now) daxyfications (more may be comming latter). | ||
| Comments: | By: Serge Vecher (serge-v) 2005-10-06 16:03:42 "RTP is deffined on RFC 3550" should be "RTP is defined in RFC 3550" By: Jose Pablo Fernandez (pupeno) 2005-10-06 17:54:10 Oh, thank you. We, spanish speakers, have only one word "en" for "in", "on" and "at" making it hard to find out which one to use. Anyway, I have more documentation to sumbit, I'll check this and I'll probably submit it tomorrow (from work, where it is). By: Clod Patry (junky) 2005-10-06 18:30:01 Your doxygen addition is invalid. Plus define all that in the header files, not in the src files. By: Jose Pablo Fernandez (pupeno) 2005-10-06 18:37:58 Why is it invalid ? I'll move my doxygen comments to the header files, sorry (I've been using languages that don't have header files for some time already). By: Clod Patry (junky) 2005-10-06 23:16:22 take a look in other header files and you'll see. By: Jose Pablo Fernandez (pupeno) 2005-10-07 15:47:27 I am sorry junky, I don't see what you mean. If it is because I used the JavaDoc style instead of the Qt style, then the change is trivial and I have already submited code decumented with the JavaDok style and it was accepted. Please cofirm me that it is that and I'll change it. In the patch I'll be attaching shortly, I've moved some of the documentation to the header, but there are some fuctions that are not declared on the header, so I left the documentation on the .c file. If there's anything else I should change, please, tell me. By: Jose Pablo Fernandez (pupeno) 2005-10-07 16:04:27 rtp-indentation-and-documentation.patch also includes more documentation. By: Russell Bryant (russell) 2005-10-10 01:56:23 Your documentation changes use a different format than that used in all of the other files. Please look at some other files in include/asterisk/ for examples. Thanks By: Jose Pablo Fernandez (pupeno) 2005-10-12 15:01:54 rtp-indentation-and-documentation2.patch switches to Qt-style dexygen comments and some styling similar to othe files I saw on inculde/asterisk/. By: Russell Bryant (russell) 2005-10-12 16:51:40 added to cvs head with some minor modifications, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:50:37.000-0600 Repository: asterisk Revision: 6752 U trunk/include/asterisk/rtp.h U trunk/rtp.c ------------------------------------------------------------------------ r6752 | russell | 2008-01-15 15:50:37 -0600 (Tue, 15 Jan 2008) | 2 lines fix some formatting and add some comments (issue ASTERISK-5257) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6752 | ||