Summary:ASTERISK-05246: [patch] [post 1-2] Add the video stream for AGI function STREAM FILE
Reporter:Belaid Arezqui (areski)Labels:
Date Opened:2005-10-05 10:42:24Date Closed:2006-05-26 12:44:02
Versions:Frequency of
Environment:Attachments:( 0) asterisk-agi_streamfile_video_raw.1.patch
( 1) asterisk-agi_streamfile_video_raw.2.patch
Description:Allow AGI command 'STREAM FILE' to play also the
video stream.
It's quite straightforward!
I am going on with the other AGI commands...


Tested with EyeBeam and it works like charm :D
Comments:By: Belaid Arezqui (areski) 2005-10-05 13:33:28

The second patch (asterisk-agi_streamfile_video_raw.2.patch)
include also the modification for the GET OPTION AGI command.
FYI, it's not necessary for GET DATE or CONTROL STREAM FILE.
PAUSE work well with CONTROL STREAM FILE but not the FORWARD,
BACKWARD, I guess we need something in the h263_seek function
:( any directions/ideas ?

By: opsys (opsys) 2005-12-30 17:50:27.000-0600

Still applies cleanly to SVN-TRUNK rev. 7682

By: Matt O'Gorman (mogorman) 2006-01-11 18:18:09.000-0600

looks okay to me.  can anyone else confirm if the patch is good?

By: Matthew Nicholson (mnicholson) 2006-01-11 21:03:13.000-0600

This code looks good except it is duplicated several places.  ast_streamfile cannot be used to remedy this because it does not support seeking a stream before playback.  Perhaps another function (ast_seek_streamfile maybe) should be written to handle this.

By: Matt O'Gorman (mogorman) 2006-03-03 13:41:13.000-0600

areski if you are still intrested in pursuing bug please follow suggestions of mnicholson

By: Belaid Arezqui (areski) 2006-03-06 03:58:35.000-0600

mnicholson, can you give more details about "it is duplicated in several places".
btw I will then do the needed modifications.

By: Matthew Nicholson (mnicholson) 2006-03-06 11:54:29.000-0600

The code for opening and streaming a file is duplicated in your patch and really throughout res_agi.  The ast_openstream, ast_seekstream, ast_applystream, and ast_playstream sequence could probably be made into a function similar to ast_streamfile.  Maybe something like a ast_seek_and_streamfile or something.

By: Rui Coelho (rjc) 2006-04-04 12:12:30

areski, can you provide a agi and .h263 samples to test your patch ? I get "Ooh, found video stream, too", but video doesn't show, only the audio. I'm using eyeBeam 1.1 3010n, res_agi.c rev. 11382, agi-test.agi and ffsdhow to encode a .h263 file.

By: Belaid Arezqui (areski) 2006-04-18 10:12:58

well actually you can record one really quickly with the voicemail.
otherwise you can check out this one

By: Serge Vecher (serge-v) 2006-05-04 11:08:08

areski: can you please update your patch here to latest trunk, including comments by mnicholson?


By: Joshua C. Colp (jcolp) 2006-05-26 12:44:00

In trunk as of revision 30547 with minor mods. Everyone give it a whirl! Thanks.