| Summary: | ASTERISK-05218: [patch] [post 1.2] Expand fullcontact length | ||
| Reporter: | Olle Johansson (oej) | Labels: | |
| Date Opened: | 2005-10-03 04:03:51 | Date Closed: | 2006-01-06 02:22:05.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) contactsize.txt | |
| Description: | I got a SIP debug from a SNOM phone with 160 character contact... | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-10-04 20:02:01 I'm not excited about the additional memory consumption here in private structures... our_contact doesn't need to be any longer, since I can't see how Asterisk could ever generate a contact string longer than the old maximum. How about making this a compile time option, defaulting to the existing size? If people start running into this problem often we can think about changing the default, but adding 256 bytes to every private structure is an awful lot... By: Olle Johansson (oej) 2005-10-05 11:41:51 Let's avoid this discussion and malloc the thing... By: Brian West (bkw918) 2005-10-26 15:09:09 memory is cheap and malloc is the least of your problems in chan_sip. By: Kevin P. Fleming (kpfleming) 2006-01-05 12:14:03.000-0600 This is no longer an issue in SVN trunk; the string fields in the SIP private structure no longer have fixed lengths. By: Olle Johansson (oej) 2006-01-06 02:21:51.000-0600 ..and that's why this bug was closed earlier on! | ||