Summary:	ASTERISK-05207: [patch] Manager connection remains open after Logoff
Reporter:	nicolasg (nicolasg)	Labels:
Date Opened:	2005-09-30 20:06:14	Date Closed:	2008-01-15 15:50:03.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 5350.txt
Description:	The recent manager changes introduced some annoying bugs: * Every manager action you send returns its data as usual, and finally a Response: Error (Invalid/unknown command) * After sending an Action: Logoff, it greets you but the connection remains open. Tested on two machines (i386 and ppc) and confirmed with drumkilla on IRC. ****** ADDITIONAL INFORMATION ****** Sample session: Asterisk Call Manager/1.0 Action: Login Username: user Secret: secret Response: Success Message: Authentication accepted Action: Status Response: Success Message: Channel status will follow Event: StatusComplete Response: Error Message: Invalid/unknown command Action: Logoff Response: Goodbye Message: Thanks for all the fish. Action: I wan't out!! Response: Error Message: Invalid/unknown command Action: please let me logoff Response: Error Message: Invalid/unknown command (the connection remains open forever)
Comments:	By: Clod Patry (junky) 2005-10-03 22:45:37 With this patch: Escape character is '^]'. Asterisk Call Manager/1.0 Action: Login Username: junky Secret: s Response: Success Message: Authentication accepted Action: Ping Response: Pong Action: Logoff Response: Goodbye Message: Thanks for all the fish. Connection closed by foreign host. polux:/usr/src/asterisk# Plus this not affects these cases: Response: Error Message: Missing action in request Response: Error Message: Missing action in request Response: Error Message: Missing action in request Action: foobar Response: Error Message: Invalid/unknown command Dunno if its the right way, but at least, it works fine on this dev box. By: Kevin P. Fleming (kpfleming) 2005-10-04 18:20:25 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:50:03.000-0600 Repository: asterisk Revision: 6715 U   trunk/manager.c ------------------------------------------------------------------------ r6715 | kpfleming | 2008-01-15 15:50:03 -0600 (Tue, 15 Jan 2008) | 2 lines allow manager actions to properly close the session again (issue ASTERISK-5207) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6715