Summary:	ASTERISK-05194: Makefile detection of $MODCONF is broken, causes failure during make install
Reporter:	timecop (timecop)	Labels:
Date Opened:	2005-09-29 19:34:48	Date Closed:	2008-06-07 11:04:57
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	If a system does not use automatic module loading, and thus does not have /etc/modules.conf or whatever the makefile is searching for, then later on during make install it will error: if [ -f  ]; then mv -f  .bak ; fi mv: missing file argument Try `mv --help' for more information. make: *** [install] Error 1 Proposed solution would be to either: a) assign default value of MODCONF variable to /etc/modules.conf b) provide a default else fallback which assigns it to /etc/modules.conf c) modify the Makefile to skip mucking with modules.conf location if the file was not found (MODCONF is unassigned)
Comments:	By: timecop (timecop) 2005-09-29 19:44:53 c) being the preferred solution since there's more failures related to modules.conf if the file doesn't exist. By: Kevin P. Fleming (kpfleming) 2005-09-30 12:01:15 I've committed option C to CVS HEAD, although keep in mind that the module configuration file is not just used for automatic module loading... but we should still support systems that don't have one. By: Digium Subversion (svnbot) 2008-06-07 11:04:57 Repository: dahdi Revision: 787 U   trunk/Makefile ------------------------------------------------------------------------ r787 | kpfleming | 2008-06-07 11:04:55 -0500 (Sat, 07 Jun 2008) | 2 lines don't try to mess with module configuration file if it's not found (issue ASTERISK-5194) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=787