Summary:	ASTERISK-05179: Recent RPID patch wasn't commited with the build_rpid in the right location.
Reporter:	Brian West (bkw918)	Labels:
Date Opened:	2005-09-28 19:27:11	Date Closed:	2008-01-15 15:50:16.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	They need to be around this line: if (ast_test_flag(p, SIP_OUTGOING)) { And removed from where they are currently.   Otherwise it doesn't work at all.
Comments:	By: Kevin P. Fleming (kpfleming) 2005-09-28 23:16:55 The function that is calling build_rpid() contains no such line, but there are three other places that seem to match what you are referring to... I can't immediately see where it should go :-( By: Brian West (bkw918) 2005-09-29 08:47:12 if (ast_test_flag(p, SIP_OUTGOING)) {                                                                                                                               add_header(req, "From", of);                                                                                                                                    add_header(req, "To", ot);                                                                                                                                  } else {                                                                                                                                                            add_header(req, "From", ot);                                                                                                                                    add_header(req, "To", of);                                                                                                                                  }                                                                                                                                                               add_header(req, "Contact", p->our_contact);                                                                                                                     copy_header(req, orig, "Call-ID");                                                                                                                              add_header(req, "CSeq", tmp);                                                                                                                                                                                                                                                                                                   add_header(req, "User-Agent", default_useragent);               Around line 4017 By: Brian West (bkw918) 2005-09-29 09:55:49 Even if you do put the code in the right place some changes since that will cause rpid not to work and will always have the number your calling as the rpid which is wrong. /b By: Brian West (bkw918) 2005-09-29 09:58:37 chan_sip 1.867 with the small mod works fine.. This has been done since then: 1.868 - store tag in the private structure as formatted text, instead of formatting every time we send a packet 1.869 - 486 (and friends) are really BUSY (bug ASTERISK-5115) 1.870 - removed some locks nothing major 1.871 - don't replace CLID/CNAM when RPID is being generated (issue ASTERISK-5158) I suspect the 1.871 or the 1.868 to have changed the behavior to cause it not to work correctly. /b By: Brian West (bkw918) 2005-09-30 10:06:59 Just for the record the patch for 5301 causes the rpid to send the called number as the callerid. /b By: Kevin P. Fleming (kpfleming) 2005-10-04 20:36:02 That is impossible! The diff for revs 1.870 to 1.871 shows only a change that controls when we set to 'unknown' CLID and CNAM, it does not affect anything else. By: Kevin P. Fleming (kpfleming) 2005-10-04 21:34:04 OK, there were quite a few problems with what got committed... but not related to any of the subsequent changes. It seems to work properly now :-) By: Digium Subversion (svnbot) 2008-01-15 15:50:15.000-0600 Repository: asterisk Revision: 6728 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r6728 | kpfleming | 2008-01-15 15:50:15 -0600 (Tue, 15 Jan 2008) | 2 lines ensure that Remote-Party-ID is sent even on secondary INVITEs within a dialog (issue ASTERISK-5179) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6728 By: Digium Subversion (svnbot) 2008-01-15 15:50:16.000-0600 Repository: asterisk Revision: 6729 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r6729 | kpfleming | 2008-01-15 15:50:16 -0600 (Tue, 15 Jan 2008) | 2 lines ensure that the correct flags are always copied from peers/users to private structures (so RPID sending will work properly, issue ASTERISK-5179) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6729