| Summary: | ASTERISK-05171: [patch] [post 1.2] SipGetPeerData | ||
| Reporter: | Shane Spencer (whardier) | Labels: | |
| Date Opened: | 2005-09-28 02:19:55 | Date Closed: | 2005-09-28 10:42:50 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sipgetpeerdata-092705-1120.txt | |
| Description: | I am not wonderfull with words. However I will start development soon on an application to help with physical zone based paging and directed intercom support for Sip based phones. To do this I needed to recall the useragent and possibly IP for a sip peer. This new application is SIPGetPeerData and requires a peername and the variable name (in a variety if different arrangements) according to the sip_peer struct as well as the description from 'sip show peer' | ||
| Comments: | By: Michael Jerris (mikej) 2005-09-28 08:25:14 Please review the bug guidelines and formatting guidelines, at quick review there are some formatting guideline issues with this patch, aslo, a discalimer will be required to review this patch, more information on discalimers is available on the main page at bugs.digium.com By: Serge Vecher (serge-v) 2005-09-28 08:57:28 whardier, take a look at SIPPEER function added to CVS a while ago http://bugs.digium.com/view.php?id=4728. I think your code is duplicating at least some of the functionality (also functions are favored over apps for this sort of thing). At least, you could probably extend it... By: Shane Spencer (whardier) 2005-09-28 10:27:00 Actually.. this patch is quite broken so don't even attempt it.. I am going to look at the SIPPEER function. By: Shane Spencer (whardier) 2005-09-28 10:37:42 yes.. just completely disreguard this patch all together :) SIPPEER(ext:useragent) did exactly what it was supposed to. By: Michael Jerris (mikej) 2005-09-28 10:42:45 Closed at OPs request. | ||