[Home]

Summary:ASTERISK-05164: [patch] no update of use count and possible memory leak in app_chanisavail
Reporter:Armin Schindler (armin)Labels:
Date Opened:2005-09-27 15:47:52Date Closed:2008-01-15 15:49:30.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_chanisavail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chanisavail.patch
Description:In two cases the function just returns without calling LOCAL_USER_REMOVE(). The attached patch fixes that issue.
Comments:By: Michael Jerris (mikej) 2005-09-27 15:52:13

Do you have a disclaimer on file with digium?
By: Armin Schindler (armin) 2005-09-27 16:16:31

Not that I know of. What does it mean and what is the background for that?
By: Michael Jerris (mikej) 2005-09-27 22:03:58

infomation on disclaimers can be found on the main page of bugs.digium.com and in the bug guidelines.
By: Armin Schindler (armin) 2005-09-28 10:20:58

I don't see any reason for signing such a disclaimer. From my point of view, I'm contributing to GPL code, nothing more or less. I understand the GPL and act according to that. If you somehow cannot add other GPL code, then I don't understand it.
Anyway, my attached patch is just a 2 line fixup. You can fix it without that patch in the same or in another way. I just wanted to help and prepared the work.
By: Michael Jerris (mikej) 2005-09-28 10:41:43

The disclaimer is necessary due to the dual license of asterisk, you can search the mailing lists for exaustive discussion of the matter.
By: Russell Bryant (russell) 2005-09-28 15:46:08

fixed in cvs head without the patch
By: Kevin P. Fleming (kpfleming) 2005-09-28 15:48:36

Patches that small carry no 'copyright' anyway, since they do not qualify as a 'substantive change' to the existing work. In this case, no disclaimer is actually needed.
By: Digium Subversion (svnbot) 2008-01-15 15:49:30.000-0600

Repository: asterisk
Revision: 6678

U   trunk/apps/app_chanisavail.c

------------------------------------------------------------------------
r6678 | russell | 2008-01-15 15:49:30 -0600 (Tue, 15 Jan 2008) | 2 lines

make sure to LOCAL_USER_REMOVE in all cases where the application can exit (issue ASTERISK-5164)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6678