[Home]

Summary:ASTERISK-05149: [patch] Asterisk Makefile tweaks
Reporter:knielsen (knielsen)Labels:
Date Opened:2005-09-26 03:07:18Date Closed:2008-01-15 15:49:42.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-make-patch1-dist.txt
( 1) asterisk-make-patch2-dist.txt
Description:We are compiling and installing Asterisk automatically from scripts into multiple different destination directories. To do this without having to modify the Makefile of asterisk for each build, we needed to slightly extend the asterisk Makefile. I think the tweaks would be of general use, so I submit them here.

****** ADDITIONAL INFORMATION ******

Changes:

1. Allow to override the values of INSTALL_PREFIX with environment variables (INSTALL_PREFIX=/myast make install).

2. Set include path so that we will take the include files zaptel.h and libpri.h from parallel zaptel and libpri source checkouts (if available) in preference to whatever version might happen to be found below /usr/.

3. Don't run mkpkgconfig if we are not root (to allow non-root installation).

Disclaimer is on file.
Comments:By: Kevin P. Fleming (kpfleming) 2005-09-26 11:58:42

I'm happy with all these changes except for the harcoded 'parallel' paths for zaptel and libpri. How about providing a couple of new variables ZAPTEL_PATH and LIBPRI_PATH (or similar) that are used to specify the include file path (and the library path, for libpri)? They could just default to $(CROSS_COMPILE_DIR)/usr.

By: knielsen (knielsen) 2005-09-27 07:00:14

kpfleming, you are absolutely right, of course.

I fixed this in a slightly different way than your suggestion. With the new patch, it is possible to specify initial values for the INCLUDE and LIBS variables. That is much more consistent; both with respect to PROC and INSTALL_PREFIX, and with respect to the fact that most (but not all) architectures already did that for LIBS.

The new patch asterisk-make-patch2-dist.txt replaces the old patch, and implements this (basically changing INCLUDE=... to INCLUDE?=... and similar for LIBS).

By: Kevin P. Fleming (kpfleming) 2005-09-29 00:09:58

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:49:42.000-0600

Repository: asterisk
Revision: 6691

U   trunk/Makefile

------------------------------------------------------------------------
r6691 | kpfleming | 2008-01-15 15:49:42 -0600 (Tue, 15 Jan 2008) | 2 lines

allow some more paths to be overridden on the command line (issue ASTERISK-5149)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6691