[Home]

Summary:ASTERISK-05139: Cut and paste error in chan_zap when ZT_EVENT_NOALARM received?
Reporter:Steve Davies . (stevedavies)Labels:
Date Opened:2005-09-24 05:18:38Date Closed:2008-01-15 15:48:54.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hi,

I was looking into a PRI problem and noticed some rather strange code on
chan_zap.c:

               case ZT_EVENT_NOALARM:
                       p->inalarm = 0;
#ifdef ZAPATA_PRI
                       /* Extremely unlikely but just in case */
                       if (p->bearer)
                               p->bearer->inalarm = 1;
#endif
                       ast_log(LOG_NOTICE, "Alarm cleared on channel %d\n", p->channel);
                       manager_event(EVENT_FLAG_SYSTEM, "AlarmClear",
                                                               "Channel: %d\r\n", p->channel);
                       break;


Now if you look in the handling of ZT_EVENT_ALARM, the code puts the bearer in alarm too.

But here in the case of ZT_EVENT_NOALARM I'd expect it to clear the bearer inalarm.  Instead, it also sets it.

This smells to me like a cut-and-paste error.

Steve
Comments:By: Mark Spencer (markster) 2005-09-24 10:22:47

Fixed in CVS head, thanks!
By: Russell Bryant (russell) 2005-09-24 17:27:28

fixed in 1.0 as well
By: Digium Subversion (svnbot) 2008-01-15 15:48:51.000-0600

Repository: asterisk
Revision: 6633

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r6633 | markster | 2008-01-15 15:48:50 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix cut/paste error (bug ASTERISK-5139)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6633
By: Digium Subversion (svnbot) 2008-01-15 15:48:54.000-0600

Repository: asterisk
Revision: 6637

U   branches/v1-0/channels/chan_zap.c

------------------------------------------------------------------------
r6637 | russell | 2008-01-15 15:48:54 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix cut/paste error (issue ASTERISK-5139)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6637