Summary:ASTERISK-05064: [patch] [post 1.2] Hangupcause to cdr_odbc + minor changes
Reporter:jalsot (jalsot)Labels:
Date Opened:2005-09-12 19:54:32Date Closed:2011-06-07 14:03:12
Versions:Frequency of
Environment:Attachments:( 0) cdr_odbc_hangupcause.txt
( 1) cdr_odbc_hangupcause2.txt
( 2) cdr_odbc_hangupcause3.txt
Description:This patch adds the hangupcause field into cdr logging (ASTERISK-5051).
Also it fixes an the 'loguniqueid' option (it affected logging of the userfield field - naming mishmatch?).
The code makes some parts more general, allowing furhter expanding of fields.
Comments:By: jalsot (jalsot) 2005-09-12 20:05:54

Maybe it would be good to move the sqlcmd preparation into odbc_load_module function, while it has be prepared only on module load/reload, saving some time [snprintfs] on logging.

By: Michael Jerris (mikej) 2005-12-01 13:48:44.000-0600

Can we please get an updated patch for this for current svn trunk.  Thanks.

By: jalsot (jalsot) 2005-12-01 14:55:09.000-0600

Uploaded an svn diff against revision 7260.

By: Tilghman Lesher (tilghman) 2006-01-05 15:38:54.000-0600

I would suggest instead of this one-off to add a field that we modify cdr_odbc to be more like cdr_custom -- to allow arbitary CDR variables to be logged into arbitrary fields, as defined in a configuration file, not as defined in the source.

That would make the next addition that you want to make not need a change to the source, only a change to your CDR table and configuration file.

By: jalsot (jalsot) 2006-01-11 12:12:11.000-0600

Unfortunately I'm not a real C coder, but I will try to make my best (right now I don't use ODBC, so don't have environemt to test/develop).
If somebody feels to make this configuration feature, let's make :)

By: Leif Madsen (lmadsen) 2006-05-02 22:46:36


Any update on this?

Edit: actually, I guess since this is a feature, we're probably not going to do anything with it right now

By: jalsot (jalsot) 2006-05-03 11:18:08

While the base of this feature (ASTERISK-5051) has been closed without commiting, this can be closed as well.
Tired of arguing why hangupcasue a good thing in CDRs...

By: Tilghman Lesher (tilghman) 2006-05-03 11:35:35

I'm not arguing that hangupcause would be a good thing in CDRs; I just think that if we're going to track it in the CDR, then it should *move* to the CDR (not be duplicated in the CDR).

By: Russell Bryant (russell) 2006-05-20 11:00:26

Since this patch depends on code posted in 5187, which has been suspended, I am going to suspend this issue as well.  Feel free to re-open this issue or create a new one if a patch is available that addresses the concerns by Corydon.  Thanks