Summary:ASTERISK-05055: man asterisk makefile failes to install 16 sounds.
Reporter:Edward Rudd (urkle)Labels:
Date Opened:2005-09-11 21:54:38Date Closed:2008-01-15 15:47:49.000-0600
Versions:Frequency of
Environment:Attachments:( 0) soundsfix.txt
Description:The makefile in 1.2.0-beta1 does not install the following sounds



Is there a more appropriate project for the build system?
Comments:By: Michael Jerris (mikej) 2005-09-11 22:16:41

Please try patching sounds.txt with the attached soundsfix.txt, or replacing your sounds.txt withthe attached.  Does that help?

By: Edward Rudd (urkle) 2005-09-11 23:22:20

the sounds.txt file isn't the issue. It's the Makefile itself, it doesn't specify them in the bash for loop iterator.

around line 483 in the datafiles: make target

for x in sounds/demo-* sounds/vm-* sounds/transfer* sounds/pbx-* sounds/ss-* sounds/beep* sounds/dir-* sounds/conf-* sounds/agent-* sounds/invalid* sounds/tt-* sounds/auth-* sounds/privacy-* sounds/queue-*; do \

an explicit list of which sounds files is done, and the 16 mentioned in the bug report are not in that list.

By: Michael Jerris (mikej) 2005-09-11 23:33:17

Is there any good reason why not to do it like in the attached patch?

Disclaimer:  Completely untested.

By: Mark Spencer (markster) 2005-09-11 23:52:36

Some files are included for reference in the source but are not installed because they are not actually used within Asterisk as distributed (e.g. hours, minutes, seconds).  This is why we don't just install sounds/*

The others did properly need to be installed and I've corrected that now.

By: Digium Subversion (svnbot) 2008-01-15 15:47:49.000-0600

Repository: asterisk
Revision: 6563

U   trunk/Makefile
U   trunk/apps/app_chanspy.c
D   trunk/sounds/agent.gsm
D   trunk/sounds/h323.gsm
D   trunk/sounds/iax.gsm
D   trunk/sounds/iax2.gsm
D   trunk/sounds/mgcp.gsm
D   trunk/sounds/sip.gsm
D   trunk/sounds/skinny.gsm
A   trunk/sounds/spy-agent.gsm
A   trunk/sounds/spy-h323.gsm
A   trunk/sounds/spy-iax.gsm
A   trunk/sounds/spy-iax2.gsm
A   trunk/sounds/spy-mgcp.gsm
A   trunk/sounds/spy-sip.gsm
A   trunk/sounds/spy-skinny.gsm
A   trunk/sounds/spy-zap.gsm
D   trunk/sounds/zap.gsm
U   trunk/sounds.txt

r6563 | markster | 2008-01-15 15:47:48 -0600 (Tue, 15 Jan 2008) | 2 lines

Properly install appropriate sound files, prefix spy ones with spy- (bug ASTERISK-5055)