[Home]

Summary:ASTERISK-05033: make valgrind fails on os x
Reporter:Roy Sigurd Karlsbakk (rkarlsba)Labels:
Date Opened:2005-09-09 03:03:12Date Closed:2008-01-15 15:48:10.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) astmm_darwin.patch
Description:compiling asterisk from cvs head on os x fails with target valgrind

****** ADDITIONAL INFORMATION ******

gcc  -pipe  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g  -Iinclude -I../include -D_REENTRANT -D_GNU_SOURCE  -O6    -include /Users/roy/src/cvs/asterisk/head/asterisk/include/asterisk/astmm.h      -fomit-frame-pointer  -D__Darwin__   -c -o sched.o sched.c
In file included from include/asterisk/utils.h:35,
                from include/asterisk/channel.h:53,
                from sched.c:32:
include/asterisk/strings.h:218: error: parse error before string constant
include/asterisk/strings.h:218: warning: function declaration isn't a prototype
make[1]: *** [sched.o] Error 1
make: *** [dont-optimize] Error 2
Comments:By: Olle Johansson (oej) 2005-09-09 03:53:22

Which version of OS/X?
By: Olle Johansson (oej) 2005-09-09 03:53:41

Please file portability bugs under portability. Thank you! Takk!
By: Roy Sigurd Karlsbakk (rkarlsba) 2005-09-09 03:57:16

sorry.
this is 10.4.2, the latest version
for what i can see, there's a typo or something in strings.h. i tried to compile that code snippet on linux as well, but it didn't work. same result with gcc 3.3 and 4.0 (the latter being default on os x)
By: Brian West (bkw918) 2005-09-09 09:25:44

Valgrind is an x86 memory debugger.  It will not work properly on OS X PPC.

/b
By: Russell Bryant (russell) 2005-09-09 12:16:28

'make valgrind' has nothing to do with actually using valgrind.  It just does an un-optimized build, which is still necessary to get a decent backtrace on a mac.


By: Russell Bryant (russell) 2005-09-09 12:25:39

'make valgrind' (the same thing as 'make dont-optimize') works fine for me on my mac.  Is this a patched version of Asterisk?  Can you try building it with a fresh checkout?
By: Roy Sigurd Karlsbakk (rkarlsba) 2005-09-10 05:10:24

this is latest cvs
the only change compared to the regular CVS HEAD is that astmm has been enabled in the makefile

roy
By: Roy Sigurd Karlsbakk (rkarlsba) 2005-09-10 05:22:07

Sorry
I just saw I've forgot to say "THIS FAILS WITH ASTMM ENABLED IN THE MAKEFILE"
without astmm, all works well

roy
By: Russell Bryant (russell) 2005-09-10 17:34:19

Cool.  Well, I'm glad everything is working as expected.  :)
By: Roy Sigurd Karlsbakk (rkarlsba) 2005-09-11 01:26:52

wait!

this is still an issue with 'make valgrind' with astmm enabled in the makefile. if I'm to test CVS HEAD, I do want astmm, and without 'make valgrind' backtraces are usually useless.

roy
By: Russell Bryant (russell) 2005-09-13 22:25:18

So, it turns out that this wasn't realted to 'make dont-optimize' at all.  MALLOC_DEBUG did not work on mac at all.

The attached patch clears things up.
By: Kevin P. Fleming (kpfleming) 2005-09-13 22:32:11

Committed to CVS HEAD, thanks!
By: Roy Sigurd Karlsbakk (rkarlsba) 2005-09-14 04:39:22

with today's CVS, i get this error when trying to 'make valgrind'
it doesn't matter if astmm is enabled or not

roy

sh mkpkgconfig /usr/lib/pkgconfig
sed: illegal option -- r
usage: sed script [-Ean] [-i extension] [file ...]
      sed [-an] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: illegal option -- r
usage: sed script [-Ean] [-i extension] [file ...]
      sed [-an] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: illegal option -- r
usage: sed script [-Ean] [-i extension] [file ...]
      sed [-an] [-i extension] [-e script] ... [-f script_file] ... [file ...]
mkpkgconfig: line 25: /usr/lib/pkgconfig/asterisk.pc: Permission denied
make[1]: *** [datafiles] Error 1
make: *** [dont-optimize] Error 2
Eplekjekken:~/src/cvs/asterisk/head/asterisk roy$
By: Michael Jerris (mikej) 2005-09-14 05:28:31

Please open up a new bug for a new issue, which this is.  I know this is known to work as it was tested last night, please try to upgrade your sed before opening a new bug.
By: Digium Subversion (svnbot) 2008-01-15 15:48:10.000-0600

Repository: asterisk
Revision: 6587

U   trunk/astmm.c
U   trunk/include/asterisk/strings.h
U   trunk/utils.c

------------------------------------------------------------------------
r6587 | kpfleming | 2008-01-15 15:48:09 -0600 (Tue, 15 Jan 2008) | 2 lines

don't double define our own string functions on platforms that don't have them (issue ASTERISK-5033)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6587