Summary:ASTERISK-05032: [patch] Support OSP Toolkit 3.3.3
Reporter:Di-Shi Sun (homesick)Labels:
Date Opened:2005-09-08 21:11:19Date Closed:2008-01-15 15:49:08.000-0600
Versions:Frequency of
Environment:Attachments:( 0) osp_paths.patch
Description:In order to support the new release of OSP Toolkit 3.3.3, Asterisk should change OSP include and lib paths. The new include path is /usr/local/include/osp. The new lib path is /usr/local/lib. The OSP library name is also changed to libosptk.a because other packages in Linux use the same library name. There are three Makefiles should be modified, asterisk/apps/Makefile, asterisk/res/Makefile, and asterisk/Makefile.


Disclaimer signed by TransNexus, Inc. 1/27/05
Comments:By: Olle Johansson (oej) 2005-09-09 02:46:15

Any reason for not having any backwards compatibility?

Also, is this really a MAJOR issue?

By: Di-Shi Sun (homesick) 2005-09-09 08:05:07

The current build procedures overwrite an existing library of others. Backward compatibility will be addressed in the build instructions.

It may be a minor bug. The new OSP Toolkit version will be released within the next week, Asterisk cannot support it without these patches.

By: Olle Johansson (oej) 2005-09-09 08:11:49

No, but not everyone will immedieately upgrade to a new toolkit. We have people using really old versions of Asterisk out there, almost over three months old!

What I am saying is that this patch disables all support of an old toolkit and now I realize that you are proposing that we patch so that we support a yet unreleased toolkit. I do not think that is the way forward.

Can we make a patch so that we check version of installed toolkit and adopt to that?

By: Olle Johansson (oej) 2005-09-09 08:12:39

Maybe Asterisk 1.2 should support the old toolkit for stability and 1.3 and forward should support the new.

By: Di-Shi Sun (homesick) 2005-09-09 08:40:57

I agree with you. I should mention that we do not think this (also 0005159) is a high priority patch for Asterisk 1.2. We just want to commit it into CVS HEAD.

By: Olle Johansson (oej) 2005-09-09 08:47:46

Still like to see a Makefile that checks the OSP library version and adopts if possible.

By: Michael Jerris (mikej) 2005-09-14 00:10:12

If we get a patch with proper checking for osp lib version, this should go in before 1.2.  Can you produce the patch?

By: Di-Shi Sun (homesick) 2005-09-14 08:22:52

We will post the new patches with osp lib version checking today. Thanks.

By: Di-Shi Sun (homesick) 2005-09-14 12:53:32

The new patch (osp_patchs.patch) has been posted. This patch will check the OSP Toolkit version by looking up osp.h file. If it is in /usr/local/include/osp, this is version 3.3.3 or higher, OSP library is /usr/local/lib/libosptk.a. If it is in /usr/include/osp, this is the version before 3.3.3, OSP library is /usr/lib/libosp.a. If there is not osp.h in these two places, Asterisk should not support OSP.

This patch is for CVS HEAD 9/14/05.

This patch will change three files, asterisk/apps/Makefile, asterisk/res/Makefile, and asterisk/Makefile.

BTW, who can tell me how to delete the old pathes from this ticket? It always says "Access Denied" when I attempt to delete them.

By: Kevin P. Fleming (kpfleming) 2005-09-25 16:53:55

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:49:08.000-0600

Repository: asterisk
Revision: 6653

U   trunk/Makefile
U   trunk/apps/Makefile
U   trunk/res/Makefile

r6653 | kpfleming | 2008-01-15 15:49:07 -0600 (Tue, 15 Jan 2008) | 2 lines

support new version of OSP toolkit (issue ASTERISK-5032)