Summary: | ASTERISK-05011: [PATCH] Transfer app never reports TRANSFERSTATUS = FAILURE | ||
Reporter: | mikma (mikma) | Labels: | |
Date Opened: | 2005-09-06 16:41:28 | Date Closed: | 2008-01-15 15:47:30.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) transfer.patch | |
Description: | The Transfer application tests the return value of ast_transfer for non-zero, but it is always non-zero since the function won't be called if transfer isn't supported. ast_transfer return values: -1 (<0 ?) failure 0 unsupported 1 (>0 ?) success | ||
Comments: | By: Russell Bryant (russell) 2005-09-07 08:06:40 Why don't we change the return values of ast_transfer to return 0 on success and non-zero on a failure? That would make more sense to me ... By: Kevin P. Fleming (kpfleming) 2005-09-07 17:38:31 It needs to support three return values, so the current semantics are fine. By: Kevin P. Fleming (kpfleming) 2005-09-07 17:39:55 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:47:30.000-0600 Repository: asterisk Revision: 6542 U trunk/apps/app_transfer.c ------------------------------------------------------------------------ r6542 | kpfleming | 2008-01-15 15:47:29 -0600 (Tue, 15 Jan 2008) | 2 lines ensure that TRANSFERSTATUS can return FAILURE (issue ASTERISK-5011) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6542 |