| Summary: | ASTERISK-05007: [patch] Fix silly ERROR messages in chan_sip | ||
| Reporter: | paradise (paradise) | Labels: | |
| Date Opened: | 2005-09-06 11:50:48 | Date Closed: | 2008-01-15 15:47:27.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_sip.c.txt ( 1) chan_sip.c.v2.txt ( 2) chan_sip.c.v3.txt | |
| Description: | just a small fix on this cool message in ERROR logs. ;-) ERROR[3726] chan_sip.c: Call from user '12' removed from call limit 2 ERROR[3726] chan_sip.c: Call from user '54' removed from call limit 2 | ||
| Comments: | By: Olle Johansson (oej) 2005-09-06 11:58:41 The second one is actually an error message. Please add if (option_debug > 1 || sipdebug) in front of the debug messages, so we only get them at debug level 2 or if sipdebug turned on. By: paradise (paradise) 2005-09-06 13:26:18 new fix uploaded By: Olle Johansson (oej) 2005-09-06 15:15:40 Sorry, wrong again. The first message is a DEBUG message and should have the option_debug etc. The second message is still an ERROR message. By: paradise (paradise) 2005-09-06 15:42:32 oops! another fix uploaded. By: Michael Jerris (mikej) 2005-09-06 17:34:09 looks like that last patch is against your previous patched version.. the second one is really just an error message and shouldn't be changed at all if I read oej's notes right. You might want to try a fresh checkout of the file and then doing a cvs diff -u to create the patch. By: paradise (paradise) 2005-09-06 23:59:00 NO, it's made againt CVS HEAD code the mentioned ERROR is left as is. just i put another DEBUG msg into "if (option_debug > 1 || sipdebug) " condition By: Michael Jerris (mikej) 2005-09-07 00:20:27 I see now, was just glancing at line numbers before.. it is the debug message a few lines up from the previos error you were messing with. Looks good to me. By: Kevin P. Fleming (kpfleming) 2005-09-07 16:54:23 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:47:27.000-0600 Repository: asterisk Revision: 6539 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r6539 | kpfleming | 2008-01-15 15:47:26 -0600 (Tue, 15 Jan 2008) | 2 lines ensure debug messages are only output if debug is enabled (issue ASTERISK-5007) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6539 | ||