[Home]

Summary:ASTERISK-04955: [patch] notifies sent out after the expiry period of the subscription have the state 'idle'
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2005-09-01 07:04:47Date Closed:2008-01-15 15:47:00.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Subscriptions
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sipsubscribe-20050901.rev832.txt
( 1) sipsubscribe-20050902.rev835.txt
Description:notifies sent out after the expiry period of the subscription have the state 'idle'.
in handle_request_subscribe the state of an extension is stored in the variable 'firstate', but this variable is initialised with 0 (idle) and not recalculated after a resubscribe (p->lastinvite != 0).


****** STEPS TO REPRODUCE ******

* subscribe for an extension
* wait for the expiry of the subscription (to shorten this set maxexpiry to a short interval)
* notifies are sent out with the state 'idle' instead of the real state

****** ADDITIONAL INFORMATION ******

this bug was introduce due to a last minute change of bug ASTERISK-3564
recommended for 1.2!!
Comments:By: Frank Sautter (xylome) 2005-09-01 07:13:36


By: Kevin P. Fleming (kpfleming) 2005-09-01 18:30:24

Your patch contains unrelated changes; please post them separately.
By: Frank Sautter (xylome) 2005-09-02 03:32:22

removed unrelated stuff
By: Kevin P. Fleming (kpfleming) 2005-09-02 15:24:27

Committed to CVS HEAD with minor mods, thanks!

(When you get a compiler warning because a function isn't expecting to get a 'const' parameter but you have one to pass, please change the function's prototype instead of casting to get around it)
By: Digium Subversion (svnbot) 2008-01-15 15:47:00.000-0600

Repository: asterisk
Revision: 6509

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r6509 | kpfleming | 2008-01-15 15:47:00 -0600 (Tue, 15 Jan 2008) | 2 lines

ensure that notify message sent out have the correct state (issue ASTERISK-4955 with minor mods)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6509