| Summary: | ASTERISK-04933: [patch] subscriptions on snom phones no longer work, due to an error in the last minute change of bug #3644 | ||
| Reporter: | Frank Sautter (xylome) | Labels: | |
| Date Opened: | 2005-08-30 05:58:52 | Date Closed: | 2008-01-15 15:46:18.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Subscriptions |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 3644ii.txt ( 1) sipsubscribe-20050830.rev827.txt | |
| Description: | this resolves the problem, that subscriptions are being changed into 'timeout'-mode just after they are registered. with this patch the subscriptions are set to timeout mode when the channel is destroyed and not when the channel is scheduled to be destroyed. this patch also includes some cosmetic changes that did not went into the commit of ASTERISK-3564 * added the type of subscription to 'sip show channel' * includes the neccessary changes to sip.conf.sample introduced with ASTERISK-3564 * removed a typo (expirey->expiry) * enhanced source readability of enum ast_extension_states ****** ADDITIONAL INFORMATION ****** i was extremly happy, that ASTERISK-3564 was committed to cvs after all that time. but against all promises an unlucky last minute change was added to that patch :-/ | ||
| Comments: | By: Frank Sautter (xylome) 2005-08-30 06:01:02 maybe this is only a minor bug... sorry! By: xrobau (xrobau) 2005-08-30 06:55:56 I was just about to submit a bug report when I thought 'Ooh, I better check..' Thanks Xylome. This _does_ make subscriptions work again, with CVS-HEAD. Definately a fix prior to 1.2.0-beta2. By: Frank Sautter (xylome) 2005-08-30 08:24:19 this patch only fixes the problem partially, after an initial reset of the phone. after the expiry period or maxexpiry (see the expire bugfix for snom200 in the hanlde_request_subscribe function) all subscriptions receive a 'terminated' when the phone resubscribes. as this has to be fixed very soon (1.2) and i don't have very much time the next few days, i would kindly ask if you - olle - could have a look on this. By: Olle Johansson (oej) 2005-08-30 14:40:23 ...found out that we did not cancel destruction if a subscription was renewed. new patch uploaded. By: Kevin P. Fleming (kpfleming) 2005-08-30 17:33:38 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:46:18.000-0600 Repository: asterisk Revision: 6459 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r6459 | kpfleming | 2008-01-15 15:46:17 -0600 (Tue, 15 Jan 2008) | 2 lines don't terminate subscriptions before they should be (issue ASTERISK-4933) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6459 | ||