Summary:ASTERISK-04888: [patch] [post 1.2] cdr_csv logging parameters in cdr.conf
Reporter:Sergey Basmanov (sb)Labels:
Date Opened:2005-08-24 09:42:53Date Closed:2006-03-02 15:06:44.000-0600
Versions:Frequency of
Environment:Attachments:( 0) cdr_csv_1.diff
( 1) cdr_csv_3.diff
( 2) cdr_csv.diff
( 3) cdr.conf.diff
Description:Added 3 parameters in cdr.conf:
usegmtime=yes       ;log date/time in GMT
loguniqueid=yes     ;log uniqueid
loguserfield=yes    ;log user field
Comments:By: Sergey Basmanov (sb) 2005-08-25 02:57:45

Fixed possible memory leak in load_config()

By: Olle Johansson (oej) 2005-11-22 09:00:25.000-0600

You are forgetting to reset the values to default at reload of the module. Move the default settings into load config instead of having them in the global declaration.

(If someone had an option turned on, then comments it out in the config file, it won't revert back to default.)

Also, add documentation of this in the sample configuration file, thank you.

Finally, a few /* comments */ here and there does *not* hurt in any way. ;-)

Thank you for contributing to Asterisk!

By: Sergey Basmanov (sb) 2005-11-22 09:21:25.000-0600

Thank You for review.
Added diff to cdr.conf.sample and diff to cdr_csv.c
Now settings reset to default value before config read.
PS: please, remove cdr_csv_2.diff because I haven't read Your comments carefully, so that changes rather silly :)

By: Olle Johansson (oej) 2006-01-04 14:31:45.000-0600

Recommended for svn trunk!

Thank you for updating your patch according to my recommendations. And thank you for contributing to Asterisk!


By: Matt O'Gorman (mogorman) 2006-03-02 15:06:34.000-0600

Committed revision 11586.