[Home]

Summary:ASTERISK-04865: [patch] Counter in show version files
Reporter:Clod Patry (junky)Labels:
Date Opened:2005-08-19 21:25:06Date Closed:2008-01-15 15:44:40.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) show_version_files.txt
Description:Examples:
debian*CLI> show version files
[...]
devicestate.c             Revision: 1.5
netsock.c                 Revision: 1.1
174 files used.
debian*CLI>


It works for any matching too:
debian*CLI> show version files like iax
File                      Revision
----                      --------
chan_iax2.c               Revision: 1.332
iax2-parser.c             Revision: 1.48
iax2-provision.c          Revision: 1.13
3 files used.
debian*CLI>


But for unique filename, we don't need it, cause we know it's automatiquely 1:
debian*CLI> show version files rtp.c
File                      Revision
----                      --------
rtp.c                     Revision: 1.142
debian*CLI>
Comments:By: Olle Johansson (oej) 2005-08-21 10:36:44

I would suggest removing "used" and only have "3 files".

By: Clod Patry (junky) 2005-08-21 11:14:27

I'll leave the final sentence like that, cause we could use "x files.", "x files used.", "x files displayed", etc.

The final commiter could use the sentence he wants and it won't make any difference. The important thing is just to see that patch passed the formatting review.

By: Kevin P. Fleming (kpfleming) 2005-08-22 14:43:47

Committed to CVS HEAD with minor text change. Thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:44:40.000-0600

Repository: asterisk
Revision: 6350

U   trunk/asterisk.c

------------------------------------------------------------------------
r6350 | kpfleming | 2008-01-15 15:44:40 -0600 (Tue, 15 Jan 2008) | 2 lines

add count of files used to build Asterisk/modules (issue ASTERISK-4865 with text mod)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6350