[Home]

Summary:ASTERISK-04833: [patch] iLBC_decode/encode uses memcpy where it should use memmove because the memory might overlap.
Reporter:Brian West (bkw918)Labels:
Date Opened:2005-08-13 14:14:30Date Closed:2008-01-15 15:45:00.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/CodecInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ilbc_memmove_fix.rev0.diff
Description:As per the memcpy man page and my debugging with valgrind ilbc uses memcpy where it should use memmove because the memory can overlap.  I have tested this and it works fine.

Comments:By: silik0n (silik0n) 2005-08-13 14:22:47

Confirmed this works fine
By: Kevin P. Fleming (kpfleming) 2005-08-22 21:50:45

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:45:00.000-0600

Repository: asterisk
Revision: 6372

U   trunk/codecs/ilbc/iLBC_decode.c
U   trunk/codecs/ilbc/iLBC_encode.c

------------------------------------------------------------------------
r6372 | kpfleming | 2008-01-15 15:45:00 -0600 (Tue, 15 Jan 2008) | 2 lines

use memmove() when memory regions might overlap (issue ASTERISK-4833)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6372