Summary:ASTERISK-04832: [patch] app_voicemail - We should find the next message number before we play the beep.
Reporter:Brian West (bkw918)Labels:
Date Opened:2005-08-13 14:03:12Date Closed:2008-01-15 15:45:01.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail.rev1.diff
Description:This patch will find the next message number before we play the beep.  If you are accessing the voicemail spool over say NFS this operation can take some time since a stat operation is very expensive.  Even on the local disk with say 200 messages in a box this can still take a second or so to complete by that time the person has already started talking before we even start recording the message.  I have fixed this once in the past but someone has reversed this once again.
Comments:By: Tilghman Lesher (tilghman) 2005-08-14 10:46:09

Trivial, I know, but could you add a blank line back in before each comment?  Paragraphs make the code flow easier to read.

By: Michael Jerris (mikej) 2005-08-14 19:02:33

upadated blank line before the 1 comment, the second one already had it.

By: Brian West (bkw918) 2005-08-14 20:09:16

*SMACK* I already did it boi!


By: Tilghman Lesher (tilghman) 2005-08-15 13:40:04

Looks good; ready to go into CVS

By: Kevin P. Fleming (kpfleming) 2005-08-22 21:59:47

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:45:01.000-0600

Repository: asterisk
Revision: 6373

U   trunk/apps/app_voicemail.c

r6373 | kpfleming | 2008-01-15 15:45:01 -0600 (Tue, 15 Jan 2008) | 2 lines

do expensive 'next message number' calculation before playing sounds (issue ASTERISK-4832)