Summary:	ASTERISK-04830: [patch] [post 1.2] MeetMe - Added support for a conference max time
Reporter:	Joseph Benden (jbenden)	Labels:
Date Opened:	2005-08-13 00:29:34	Date Closed:	2006-01-18 14:38:23.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_meetme.patch-4.txt
Description:	This patch gives MeetMe the ability to limit a conference to a set number of seconds, whereby each user in the conference contributes to the total time spent on the conference.  All users of the conference are notified at the 5 minute remaining interval and at the 1 minute remaining interval.  When the time is up, all users are kicked. This patch gives the possibility of doing prepaid conferencing. In order for the conference to know how much time is allowed, it is passed in the dialplan extension like this: exten => X,1,Meetme([conf number],[options],[pin],[seconds total allowed]) exten => X,2,Hangup WARNING: Be sure to have the Hangup priority or you'll loop calls when people are kicked from the conference. NOTE: One item worth mentioning is, this patch could use better choices of phrases said to the users of the bridge; however, the point is made known.  The voice files used are a patchwork of the voicemail system. ****** ADDITIONAL INFORMATION ****** Disclaimer will be snail mailed. This patch has been tested, but not under high load. (4 people in conference.)  I will submit further patches if needed once I can get a large conference call together.
Comments:	By: Joseph Benden (jbenden) 2005-08-14 11:55:37 Uploaded new patch that hopefully better meets the coding guidelines. By: Joseph Benden (jbenden) 2005-08-14 12:00:23 Ignore patch-2, I broke the compile. patch-3 is ok. By: Joseph Benden (jbenden) 2005-08-15 13:51:07 Disclaimer was faxed this morning. By: Joseph Benden (jbenden) 2005-08-27 14:51:53 A new patch was posted, due to it miscalculating the remaining time. By: Michael Jerris (mikej) 2005-08-27 16:26:39 You say that this is cvs head, then in cvs date you mark 1.0.9.  Please make sure that this is a patch for cvs head, and not 1.0.9 as this is a new feature and will not be added to the 1.0 branch. By: Joseph Benden (jbenden) 2005-08-27 16:56:13 Ok, sorry. I always develop with the stable branch, as that is what I run for my production environment. So, the patch I posted is actually for STABLE 1.0.9. I will check out CVS HEAD and make another patch. By: Clod Patry (junky) 2005-09-08 22:58:42 Can i ask why do you combine the time from all users? To be honest, i see no need for that patch, since we can limit the time of a call with a dial. By: Joseph Benden (jbenden) 2005-09-09 08:21:33 Hello, Limiting the calls with dial would work, but wouldn't be accurate in the call durations of everyone involved in the conference call. Here's the reason.  I've got a TDM 800 number. Someone prepays for 120 minutes of conference calling. Now, no matter how many people join in the conference, I can be sure that no more than 120 minutes is used. By: BJ Weschke (bweschke) 2005-10-17 10:41:27 JBenden: Having built a pre-paid conferencing platform for a client already at www.bargainconference.com using Asterisk and the MeetMe application, I agree with your objective here. Having functionality like this would make things easier. There are a couple things we may want to consider in the implementation of this. 1) It might make sense to follow the option patterns for warnings already in use with Dial and the L option of Dial. 2) You may also want to consider the ability to adjust this value once the conference has started either via Manager or CLI actions. The reason being is because you may have multiple conferences that belong to the same card in your OSS situation (we did). Having a single value that doesn't adjust isn't going to address that additional requirement. Finally - When you did your unit testing, did you have the name record/announce enabled? I've found in earlier testing that when you have this option turned on, and then you do something like kicking everyone out of conference, you could run into the circumstance where media is queued up for channels (eg. meetme delay) and the psuedo Zap channel goes away too quickly which causes a segfault in Asterisk. You probably didn't have this problem if you didn't apply the patch where confplay is split out into a separate thread, but if you didn't apply the patch you've probably also got significant issues with MeetMe delay when you use name/record announce. :-/ By: Clod Patry (junky) 2005-10-22 00:07:06 JBenden: could you msg me on IRC, i'd like to discuss more about that patch, cause i dont feel comfortable with all this. By: opsys (opsys) 2005-12-30 18:11:17.000-0600 HOUSEKEEPING: Has this been updated for SVN-TRUNK? Have the options been fixed to mirror Dial()? By: Joseph Benden (jbenden) 2006-01-03 14:37:33.000-0600 No. I'm pretty sure it only compiles on 1.0.x. I'd just close this, unless someone wants this feature for 1.2.x. By: Matt O'Gorman (mogorman) 2006-01-18 14:36:31.000-0600 I think what bweschke said in refrence to the L option, would be the best way to take care of this. if anyone cares to reopen and solve this issue for trunk it would be appreciated. By: Olle Johansson (oej) 2006-01-18 14:38:23.000-0600 JBenden: yes, please update this for SVN trunk. All new features are only committed to trunk and it seems like something useful. Thank you for contributing this and taking time to upgrade your patch!