[Home]

Summary:ASTERISK-04828: The script contrib/safe_asterisk relies on asterisk in $PATH
Reporter:Juraj Bednar (juraj)Labels:
Date Opened:2005-08-12 16:15:15Date Closed:2008-01-15 15:44:21.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) safe_asterisk.patch.txt
Description:The script asterisk/contrib/safe_asterisk which by default gets installed into /usr/sbin (depends on asterisk install path) relies on "asterisk" binary being in the path.

This is actually not the case, the asterisk binary should be either relative to the safe_asterisk binary or configurable -- one can have several asterisk installations and the binary path being hardcoded in the script is not a good thing.

Consider at least using ASTERISKBIN environment variable set in the beggining of the script.
Comments:By: Michael Jerris (mikej) 2005-08-12 16:50:59

Patches gladly welcomed on this.  Can you produce a patch that implements what you are suggesting?
By: silik0n (silik0n) 2005-08-13 14:38:35

Add ASTERISK_BIN variable to top of file with explicit path to asterisk binary.

This could be fixed up better to allow for changes of binary destination during install
By: Mark Spencer (markster) 2005-08-13 22:16:23

Unfortunately the patch attached does not take into account the actually selected path.  I've modified CVS head to properly construct the path.  Thanks for the idea.
By: Digium Subversion (svnbot) 2008-01-15 15:44:21.000-0600

Repository: asterisk
Revision: 6327

U   trunk/Makefile
U   trunk/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r6327 | markster | 2008-01-15 15:44:21 -0600 (Tue, 15 Jan 2008) | 2 lines

Build safe_asterisk script substituting the proper path in (bug ASTERISK-4828, patch not used)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6327