Summary:	ASTERISK-04774: [patch] Record application never returns if no input is received from channel
Reporter:	jcomellas (jcomellas)	Labels:
Date Opened:	2005-08-04 12:34:38	Date Closed:	2008-01-15 15:48:31.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_record
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_record_maxduration_HEAD_2.diff ( 1) app_record_maxduration_stable_2.diff
Description:	We've been experiencing problems with the Record application (app_record module) when no input is received from the channel. This application is not taking into account the timeout (maxduration) it receives and calls ast_waitfor() with the value -1 for the ms argument. When there is no input from the channel the application waits indefinitely. This may be happening because a hangup is not being notified properly (we have other patches in Asterisk that may be causing this), but a problem exists in the application.
Comments:	By: jcomellas (jcomellas) 2005-08-04 12:36:19 I've included a fix for the HEAD version also. By: jcomellas (jcomellas) 2005-08-08 01:11:06 There was a problem with the handling of recordings with infinite timeouts. This should be corrected both for stable and HEAD in the diffs ending in "_2". By: Kevin P. Fleming (kpfleming) 2005-08-22 21:08:01 This patch looks fine, but we cannot accept it without a disclaimer being on file. By: Michael Jerris (mikej) 2005-08-24 02:58:03 bug suspended until a disclaimer is filed.  Information on discalimers can be found in the bug guidelines and on the main page at bugs.digium.com.  Please re-open this bug when a disclaimer has been filed with digium.  Thanks By: jcomellas (jcomellas) 2005-09-09 15:29:23 I've already sent my disclaimer by email. By: Kevin P. Fleming (kpfleming) 2005-09-14 21:19:33 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:44:55.000-0600 Repository: asterisk Revision: 6366 U   trunk/apps/app_record.c ------------------------------------------------------------------------ r6366 | kpfleming | 2008-01-15 15:44:54 -0600 (Tue, 15 Jan 2008) | 2 lines make Record() properly timeout even if no input is received from the channel (issue ASTERISK-4774) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6366 By: Digium Subversion (svnbot) 2008-01-15 15:48:31.000-0600 Repository: asterisk Revision: 6610 U   trunk/apps/app_record.c ------------------------------------------------------------------------ r6610 | kpfleming | 2008-01-15 15:48:30 -0600 (Tue, 15 Jan 2008) | 2 lines ensure that Record() will exit even if no audio is received from the channel (issue ASTERISK-4774) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6610