[Home]

Summary:ASTERISK-04744: [patch] chan_h323.c fails to compile
Reporter:Kaj J. Niemi (kajtzu)Labels:
Date Opened:2005-08-01 05:28:41Date Closed:2008-01-15 15:43:19.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast-h323-mistype.diff
Description:asterisk compile fails while attempting to compile chan_h323.c

gcc -pipe  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations  -Iinclude -I../include -D_REENTRANT -D_GNU_SOURCE    -DZAPTEL_OPTIMIZATIONS          -m64 -fomit-frame-pointer  -Wno-missing-prototypes -Wno-missing-declarations   -DZAPATA_PRI   -DIAX_TRUNKING   -DCRYPTO -fPIC -c -o chan_h323.o chan_h323.c
chan_h323.c: In function `oh323_alloc':
chan_h323.c:826: error: structure has no member named `newsignal'
chan_h323.c: In function `update_state':
chan_h323.c:876: error: structure has no member named `newsignal'
chan_h323.c: In function `connection_made':
chan_h323.c:1225: warning: unused variable `c'
chan_h323.c: In function `chan_ringing':
chan_h323.c:1427: warning: unused variable `c'
make[1]: *** [chan_h323.o] Error 1

Revision 1.123 of chan_h323.c introduced newstate and newcontrol to struct oh323_pvt but no newsignal...?
Comments:By: Michael Jerris (mikej) 2005-08-01 08:40:33

can you create a patch to fix the problem?
By: Kaj J. Niemi (kajtzu) 2005-08-01 08:58:14

There you go. I don't have a disclaimer on file (yet) but the fix is trivial..
By: Michael Jerris (mikej) 2005-08-01 08:59:47

are you working on a disclaimer?
By: Kaj J. Niemi (kajtzu) 2005-08-01 09:00:38

Needs to go through legal and all that.. been working on it for 2 months :-)
By: Michael Jerris (mikej) 2005-08-01 09:04:27

+ int newstate; /* Pending state change */
+ int newcontrol; /* Pending control to send */

was added in 4555, but newsignal was not...


By: Kaj J. Niemi (kajtzu) 2005-08-01 09:06:52

I wonder how this managed to compile cleanly previously.. ASTERISK-3960 is from April.
By: Kaj J. Niemi (kajtzu) 2005-08-01 09:08:45

mike: ASTERISK-4440 introduces the problem.. not ASTERISK-3960 :)
By: Paul Cadach (pcadach) 2005-08-01 11:40:10

Attached patch (ast-h323-mistype) is more correct fix than astersik-newsignal...
By: Michael Jerris (mikej) 2005-08-01 12:06:44

upgrading to major as this fails to compile.
By: jerjer (jerjer) 2005-08-01 23:22:09

commited to cvs -head
By: jerjer (jerjer) 2005-08-01 23:22:22

not in -stable
By: Digium Subversion (svnbot) 2008-01-15 15:43:19.000-0600

Repository: asterisk
Revision: 6255

U   trunk/channels/chan_h323.c

------------------------------------------------------------------------
r6255 | jeremy | 2008-01-15 15:43:18 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix newsignal/newcontrol compile issue. Bug ASTERISK-4744

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6255