Summary:ASTERISK-04730: [PATCH] show cid.cid_num and cid.cid_name in meetme list
Reporter:jaredmauch (jaredmauch)Labels:
Date Opened:2005-07-29 11:03:03Date Closed:2008-01-15 15:44:05.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_meetme.diff
( 1) meetme.patch
Description:align user# formatting and show cid of the channels in the conference (with name) to ease identification of conf members


User #: 01 1005 Jared Mauch Channel: SCCP/1005-00000003    (not talking)
Comments:By: jaredmauch (jaredmauch) 2005-08-02 08:31:13

second patch realigns output as follows:

sip-server*CLI> meetme list 4500
User #: 01         1005 Jared Mauch          Channel: SCCP/1005-00000003    (not talking)

By: Mark Spencer (markster) 2005-08-02 17:10:07

This patch doesn't check for null values for name/number

By: jaredmauch (jaredmauch) 2005-08-03 12:43:17

Is the goal of the null checking to prevent null dereference for existing channels in conference (eg: chan = null) vs chan->cid null, chan->cid.name = null?

By: jaredmauch (jaredmauch) 2005-08-03 12:48:01

existing code doesn't check for user->chan->name null, i presume that would be part of any acceptance as well?

By: Michael Jerris (mikej) 2005-08-03 13:14:20

A channel at this point would always have a name, not necessarily the cid info.

By: Mark Spencer (markster) 2005-08-03 13:27:23

chan->cid.name / chan->cid.num could be NULL...

By: Donny Kavanagh (donnyk) 2005-08-07 11:09:50

how about a flag in meetme.conf to enable disable this.  I've already written code which parses meetme list commands and i dont want a suprise someday when a cvs update breaks it :)

By: Mark Spencer (markster) 2005-08-07 22:29:25

Too short to keep waiting on.  Fixed in CVS head with appropriate mods.

juggie: Since it's a CLI command we don't guarantee parsing backwards compatibility.  Sounds like you need something from the manager interface.

By: Digium Subversion (svnbot) 2008-01-15 15:44:05.000-0600

Repository: asterisk
Revision: 6308

U   trunk/apps/app_meetme.c

r6308 | markster | 2008-01-15 15:44:05 -0600 (Tue, 15 Jan 2008) | 2 lines

Show callerid in meetme show list (bug ASTERISK-4730 with mods)