Summary:	ASTERISK-04726: bug with AMI - Originate
Reporter:	Jay Binks (jaybinks)	Labels:
Date Opened:	2005-07-29 07:10:37	Date Closed:	2008-01-15 15:43:38.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	On CVS Head ( 29-July-2005 ) when doing originate with the AMI and passing an account code. this account does does not make it into the Mysql CDR's however I Tested this against Asterisk STABLE, and it DOES work in stable.
Comments:	By: Jay Binks (jaybinks) 2005-07-29 08:13:21 this also seems to affect the Call files placed in /var/spool/asterisk/outgoing. BTW.. (I know it might be un-related) I CAN set CallerID and it works as expected.. By: Brian West (bkw918) 2005-07-29 08:35:23 show us an example of what you're sending. /b By: Jay Binks (jaybinks) 2005-07-29 09:10:29 In Call File.... ------------------------------- Channel: sip/236 Account: jay-binks-01 CallerID: jay-binks-01 Context: brisbane-qld Extension: ##MYCELLNUMBER## Priority: 1 in Manager Interface im doing exactly the same thing.... I did some looking into this (looking through the code), and although my C skills are not that great I found a few "Interesting" differences between the Stable branch and the CVS head branch of "manager.c". Namely that the fast_originate_helper structure no longer includes an Account variable. I also saw (may not mean anything) that the calling of ast_pbx_outgoing_app in function fast_originate dosnt include Account info any more either. By: jmls (jmls) 2005-08-01 11:46:31 we have this problem as well - we use the AMI to originate calls, and in CVS head (August 1 2005) there is no account code in either the cdr csv or cdr pgsql. I think the problem came with the 1.104 of manager.c. We are running a system that uses 1.101 and that system works just fine. By: Jay Binks (jaybinks) 2005-08-01 18:17:59 I will confirm that the bug exists in Mysql cdr also.. By: Mark Spencer (markster) 2005-08-02 08:01:17 The "Account:" header is being remapped to a variable CDR(accountcode|r) which apparently is not operating as expected.  While I agree with the change in general, work will have to be done to figure out why it's having trouble. By: Russell Bryant (russell) 2005-08-02 20:31:14 yikes ... I was starting with a simple extension that set the account code and it looks like we have some parsing issues. *CLI>     -- Executing Set("OSS/dsp", "CDR(accountcode|r)=blah") in new stack Aug  2 20:31:47 WARNING[10672]: pbx.c:5720 pbx_builtin_setvar: Ignoring entry 'CDR(accountcode' with no = (and not last 'options' entry) Aug  2 20:31:47 WARNING[10672]: pbx.c:1357 ast_func_write: Function doesn't contain parentheses.  Assuming null argument. Aug  2 20:31:47 ERROR[10672]: pbx.c:1368 ast_func_write: Function r) not registered By: Russell Bryant (russell) 2005-08-03 17:30:28 Ok, I just committed something that I think will fix the problem with AMI and pbx_spool.  Please retry with the latest cvs head and let me know if it fixes your problem. By: jmls (jmls) 2005-08-05 07:49:37 could you let me know what version of the file(s) the fix is in - I cannot seem to find it in CVS ... By: Russell Bryant (russell) 2005-08-05 11:04:31 The fix was included in version 1.5 of funcs/func_cdr.c By: Mark Spencer (markster) 2005-08-06 10:50:08 Did that fix it for you? By: jmls (jmls) 2005-08-08 01:28:51 works for me with latest cvs head for 1) Normal calls 2) Account() 3) AMI originate. many thanks. By: Russell Bryant (russell) 2005-08-08 14:30:37 yay! By: Digium Subversion (svnbot) 2008-01-15 15:43:38.000-0600 Repository: asterisk Revision: 6277 U   trunk/funcs/func_cdr.c ------------------------------------------------------------------------ r6277 | russell | 2008-01-15 15:43:38 -0600 (Tue, 15 Jan 2008) | 2 lines only check for an existing cdr when about to set an arbitrary cdr variable (bug ASTERISK-4726) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6277