[Home]

Summary:ASTERISK-04719: [patch] chan_sip.c: qop=auth syntax error
Reporter:Olle Johansson (oej)Labels:
Date Opened:2005-07-28 09:29:41Date Closed:2011-06-07 14:11:54
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Registration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sipqopstable.txt
Description:The current cvs version sets qop="auth", which is wrong.<br />
It has to be qop=auth (without double quotes).<br />
<br />
This prevents me to register at my registrar.

****** ADDITIONAL INFORMATION ******

http://www.faqs.org/rfcs/rfc3261.html]<br />
----------------------------------------------------------------------<br />
In the Basic Rules of RFC3261, the auth parameter is defined like this:<br />
<br />
Authorization = "Authorization" HCOLON credentials<br />
credentials = ("Digest" LWS digest-response)<br />
/ other-response<br />
digest-response = dig-resp *(COMMA dig-resp)<br />
dig-resp = username / realm / nonce / digest-uri<br />
/ dresponse / algorithm / cnonce<br />
/ opaque / message-qop<br />
/ nonce-count / auth-param<br />
message-qop = "qop" EQUAL qop-value<br />
qop-value = "auth" / "auth-int" / token<br />
<br />
That means there should be no double quote around the qop-value. An<br />
example of the Authorization header field is :<br />
<br />
Authorization: Digest username="bob",<br />
realm="biloxi.com",<br />
nonce="dcd98b7102dd2f0e8b11d0f600bfb0c093",<br />
uri="sip:bob@biloxi.com",<br />
qop=auth,<br />
nc=00000001,<br />
cnonce="0a4f113b",<br />
response="6629fae49393a05397450978507c4ef1",<br />
opaque="5ccc069c403ebaf9f0171e9517f40e41"<br />
----------------------------------------------------------------------<br />
Comments:By: Russell Bryant (russell) 2005-07-28 12:12:20

This same line exists in CVS HEAD as well.  Are you proposing that it needs to be changed there as well?
By: Olle Johansson (oej) 2005-07-28 13:52:25

That is another bug report. I forked it into two bug reports. This one is for stable ONLY.
By: Digium Subversion (svnbot) 2008-01-15 15:43:46.000-0600

Repository: asterisk
Revision: 6285

U   branches/v1-0/channels/chan_sip.c

------------------------------------------------------------------------
r6285 | russell | 2008-01-15 15:43:45 -0600 (Tue, 15 Jan 2008) | 2 lines

fix qop to be RFC compliant (bug ASTERISK-4719)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6285