[Home]

Summary:ASTERISK-04701: [patch] Mec2 Timed Agressive Cancellation
Reporter:Stephen Marron (soloflyer)Labels:
Date Opened:2005-07-27 08:39:22Date Closed:2011-06-07 14:03:14
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 0004823.diff.txt
( 1) cvshead-0004823.diff.txt
( 2) mec2_const.h.0002820.diff.txt
( 3) mec2.h.0002820.diff.txt
Description:Allows use of the aggressive echo cancelation for the amount of time defined by AGGRESSIVE_TIMELIMIT in mec2_const.h (if not defined it just does aggressive forever) after the set period of time has elapsed the non-aggressive echo canceling is used


if ( Time_Elapsed < AGGRESSIVE_TIMELIMIT ) {
  Aggressive_Cancelation();
}
else {
  Standard_Cancelation();
}

its very very simple... but it works very very well :)
Comments:By: Stephen Marron (soloflyer) 2005-07-27 10:41:07

after reading bug 002820.

I decided to include patches to add this code to cvs patched with 0002820 patch
By: Michael Jerris (mikej) 2005-07-31 20:52:39

2820 is unlikely to go in in it's curren't form.  If you would be interested in breaking it up into pieces as described in that bug that would be happily welcomed.  Until then, I would stick with basing your patches off of head.  I see quite a few patches on this bug.  Is there a single patch which does what you are looking at for head or is it the first 2?  If so, in the future please try to do single patches including changes for multiple files as it is generally easier to review if they are all necessary for the bug.  The only time where you would not want to do that if is the change is very large, such as in 2820, and you can break up the changes into pieces that can be reviewed and applied individually.  Thanks for the submition!
By: Stephen Marron (soloflyer) 2005-08-01 05:36:07

0004823.diff.txt - Diff with all nessicary modifcations, based on CVS Head as per request...


btw 0004823.diff.txt is just mec2.h.diff.txt and mec2_const.h.diff.txt rolled together :)
By: Stephen Marron (soloflyer) 2005-08-24 20:44:09

cvshead-0004823.diff.txt

Diff based on cvshead at 08-24-05 :)
By: Matthew Fredrickson (mattf) 2005-09-01 15:26:55

This is a pretty clever idea.  Good job!
By: Matthew Fredrickson (mattf) 2005-09-07 20:19:41

Committed, thanks! :-)
By: Digium Subversion (svnbot) 2008-06-07 11:02:10

Repository: dahdi
Revision: 757

U   trunk/mec2.h
U   trunk/mec2_const.h

------------------------------------------------------------------------
r757 | mattf | 2008-06-07 11:02:09 -0500 (Sat, 07 Jun 2008) | 2 lines

Add aggressive suppressor timelimit  (Bug ASTERISK-4701)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=757