[Home]

Summary:ASTERISK-04699: [branch] IPv6 support in chan_[sip,iax2]
Reporter:Gonzalo Mateos (gonchi)Labels:
Date Opened:2005-07-26 22:44:27Date Closed:2007-11-05 15:44:48.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-ipv6_20050404-Mikael-Original.patch
( 1) asterisk-ipv6_20050724.patch
Description:I'm sending a patch against de cvs head date 22/07/2005. I have tested it an ran into no problems whith the SIP channel, our staring point was the patch originaly submited by Mikael Magnusson, I still haven't teste thorougly the IAX channel.
Comments:By: Gonzalo Mateos (gonchi) 2005-07-26 22:46:58

I have also atached the cvs status of my cvs repository
By: twisted (twisted) 2005-07-26 22:49:46

sorry, but the disclaimer IS applicable in this case.  If you want the code to be considered, you need to have a disclaimer on file
By: Michael Jerris (mikej) 2005-07-26 22:58:04

also, I see that Mikael has posted the original work to the dev list.  We need a disclaimer from him as well before this can be reviewed.
By: Gonzalo Mateos (gonchi) 2005-07-27 07:47:37

My development partnet Federico Morales faxed the disclaimer on monday 26/07/2005. I will mail Mikael as to get a disclaimer from him. Do you requiere the disclaimer to by uploaded in digital format?

When the bounty for IPv6 support was posted by Bernard Schmidt he comented that he couldn't contact Mikael


By: Michael Jerris (mikej) 2005-07-27 08:28:59

faxing is the preferred way to get a disclaimer submitted.  If faxing is unavailable, you can submit a scanned copy via e-mail to digium.
By: Federico Morales (fmorales) 2005-07-27 09:53:56

I'm working with gonchi on this proyect and I already faxed the disclaimer, on monday, as gonchi said.

It was faxed to the number +1 256 864 0464 from +598 2 712 6872
By: mikma (mikma) 2005-07-28 08:11:12

Standard disclaimer on file applies to my Asterisk ipv6 patches  asterisk-ipv6_20050404*.patch.gz.

Should I upload my original patch? Unfortunately I don't have access to it currently.

/Mikael Magnusson


By: Federico Morales (fmorales) 2005-07-28 08:41:02

If the original patch is needed we have a copy of it
By: Michael Jerris (mikej) 2005-07-28 09:06:35

If you have a disclaimer already with digium, your comment on the bug should be plenty, thanks.
By: Olle Johansson (oej) 2005-08-12 02:11:17

I am a bit nervous of this patch, it will need a lot of testing. I vote for including it after 1.2 release, in the 1.3 development tree, for testing.
By: Michael Jerris (mikej) 2005-08-28 10:14:14

also, due to the size of this patch, is there any logical way it could be broken up into groups and committed in pieces, for example, can we commit the new stuff in acl.c (and other such associated new api calls) beforehand, then dig into the chan_sip changes?
By: Matt O'Gorman (mogorman) 2006-01-08 10:13:40.000-0600

marko, commit or no commit, or more info ^_^.   Also is this code portable to the other posix compliant systems (bsd, osx etc)?
By: Olle Johansson (oej) 2006-01-09 00:49:42.000-0600

THis is a patch that needs it own branch for testing before we commit.
By: Jason Parker (jparker) 2006-01-09 15:06:32.000-0600

Also, which of these are the "correct" patch?  asterisk-ipv6_20050724.patch?  That patch failed to apply.
By: Tilghman Lesher (tilghman) 2006-03-06 17:23:20.000-0600

We need an update to this patch or it will be closed due to lack of response.
By: Serge Vecher (serge-v) 2006-05-06 13:14:35

this is a valuable feature, but needs updates to move formard

mikma, gonchi, fmorales: are you guys still working on this?
By: Marc Blanchet (blanchet) 2006-05-06 13:40:20

I'm working on it with the help/guidance of kpfleming and oej. However, the submitted patch defines a new structs and related utiility functions that I don't think are needed. Moreover, they are in competition with kevin's new socket lib. So, I'm "redoing" the work (1st: chan_sip and related ; 2nd: chan_iax), based on trunk. Given the possible important impact of this work on * network stability, I will run the converted asterisk-v6enabled into production with real v6 sip clients.  current status as of today: chan_sip mostly done, acl to be done, netsock mostly done.  if you monitor this bug, I will add a note to this patch when done.
By: Matt O'Gorman (mogorman) 2006-09-26 14:21:21

any update blanchet?
By: Marc Blanchet (blanchet) 2006-09-26 14:40:10

update: see: http://lists.digium.com/pipermail/asterisk-dev/2006-September/023300.html
By: jmls (jmls) 2006-11-01 12:59:22.000-0600

any news after astricon ?
By: Olle Johansson (oej) 2007-02-20 00:48:42.000-0600

Closing this due to lack of activity.
By: Serge Vecher (serge-v) 2007-04-06 11:34:44

since there is some activity going on in team/blanchet/v6/, reopening the issue to collect feedback. Marc, if you don't want this open, please make a note.
By: Marc Blanchet (blanchet) 2007-04-06 11:45:04

I would suggest to restart a new issue (or maybe many see below), since a lot of this issue text is no more relevant. I would close it and restart new ones. Since I'm also sure the new ones will have long trails... ;-))
There are multiple facets of IP version independent code:
- netsock library
- rtp (and related udptl)
- channels: chan_sip, ....
- misc (configure.ac, acl.*, ...)

So I wonder if one issue or multiple will be appropriate. For example, for each channel, there are generic work of making IP version independent and also specific issues related to the channel being converted.

An idea for issues:
1) IPv6 port of non-channels (would have netsock, rtp, udptl, etc..)
2) IPv6 port of chan_sip
3...) IPv6 port of chan*

Your advice?  (If guys agree, I will create the issues.)
By: username (username) 2007-05-25 07:49:11

Hello.

I'm not really sure where to put this, but there is a slight error in the logic of the latest svn checkout I made against svn .../team/blanchet/v6.

Since I don't have a disclaimer I will refrain from posting some sort of patch but lets just say that the logic of the following lines of code from the function sip_alloc_fromhost() may be flawed ;)

// ...

if (!peer_param) {
if ((result = ast_vinetsock_str2hp(peer, sizeof(peer), port, sizeof(port), hoststr, 0, NULL)))
ast_log(LOG_ERROR, "Invalid host string: %s\n", hoststr);
return NULL;

p = find_peer(peer, NULL, 0, 1);
// ...

}

Making the logic match the indentation does wonders for my sip ipv6 testing.

Thanks!
By: Olle Johansson (oej) 2007-11-05 15:44:45.000-0600

If you find errors in Mark's IPv6 branch, please open a new bug report. These patches are old and not the base for our IPv6 branch.

Thanks for helping to test the IPv6 branch!

/O