Summary:ASTERISK-04679: [patch] MWI compliance with RFC3842 - "Message-Account" in NOTIFY header
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2005-07-26 05:37:55Date Closed:2008-01-15 15:44:54.000-0600
Versions:Frequency of
Environment:Attachments:( 0) mwi.rfc3842compliance.r792.txt
( 1) mwi.rfc3842compliance.r796.txt
( 2) mwi.rfc3842compliance.r796v2.txt
( 3) mwi.rfc3842compliance.r797.txt
( 4) mwi.rfc3842compliance.r801.txt
Description:currently the MWI NOTIFY messages do not contain a "Message-Account" header (in opposition to RFC3842).
this is patch necessary to make the voicemail retrieve button on snom phones work.
there is a new config file option to set the dialplan extension which should be used for the NOTIFY messages (defaults to 'asterisk' for not breaking MWI buttons of other phones).


this patch is an offspring of ASTERISK-3564
Comments:By: Olle Johansson (oej) 2005-07-26 06:14:47

I would like a setting per peer also, thank you. I configure voicemail so that peers can automatically bypass the account question and go directly to pincode.

Is the use of p->fromdomain correct, really?

By: Frank Sautter (xylome) 2005-07-26 07:02:20

oej: hmmm, i think there is a global and a per peer setting. the global setting is configured in 'reload_config' the per peer setting in 'build_peer'.

using p->fromdomain seems correct for me. it's the same domain as the domain used in the header of the mwi notify.

By: Olle Johansson (oej) 2005-07-26 07:24:26

You're right. I wasn't awake. Sorry.

For reference, from the RFC:
"   If the Request-URI or To header in a message-summary subscription
  corresponds to a group or collection of individual messaging
  accounts, the notifier MUST specify to which account the message-
  summary body corresponds.  Note that the account URI MUST NOT be
  delimited with angle brackets ("<" and ">").

     Message-Account: sip:alice@example.com
Seems like the SNOM interpretation is a bit away from the RFC. Correct notification here would be peername@ourdomain

I'll test this and check the domain issue, that might be wrong as well.

By: Olle Johansson (oej) 2005-07-26 12:07:47

Patch works fine. A suggestion: Change the From: username as well, some phones seems to use this for the voicemail button.

By: Frank Sautter (xylome) 2005-07-26 12:49:07

oej: i would like to have this commited to cvs in the current form (just as you said keep the patches small to get them digested easily). a change of the 'From' would induce a lot more changes (and i'm not able to test it's behaviour in the way i test all my other patches for functionality and stability).

By: Olle Johansson (oej) 2005-07-26 13:42:49

Ok, this patch in the current state is recommended for CVS.

By: Frank Sautter (xylome) 2005-07-27 04:55:26

updated to revision 796
maybe you add a relationship to ASTERISK-3564

By: Frank Sautter (xylome) 2005-07-28 09:39:21

added output of vmexten to 'sip show peer'

By: Olle Johansson (oej) 2005-07-28 10:39:24


By: Frank Sautter (xylome) 2005-07-29 11:08:45

update to revision 797

By: Mark Spencer (markster) 2005-08-03 00:32:39

The extension it wants seems to be the mailbox number, not the extension you dial to check voicemail.  In that sense, whatever mailbox we're checking with, that's what we should include.

By: Frank Sautter (xylome) 2005-08-03 04:31:21

mark: snom phones are using the number presented in the mwi-notify as the extension dailled when pressing the 'Retrieve Messages' button. therefore it should be configurable and different from the mailbox number! the one thing that might be dicussed is the default value used in the mwi-notify (currently i'm using 'asterisk' for not breaking current behaviour - maybe this should be the mailbox number?)

By: Frank Sautter (xylome) 2005-08-03 04:34:26

updated to revision 801

By: Olle Johansson (oej) 2005-08-04 04:39:19

We *never* use the mailbox ID as an URI, we use the peer name for subscribes. In this case, the phones use this ID as an URI to call back to check the voicemail, which is an extension, either a generic one or one that by pattern includes a voicemail ID (8500 or maybe 8500xxxx, like 85001234) - it depends on the local dialplan. I think this new config option makes sense as we do not expose mailbox IDs.

By: Kevin P. Fleming (kpfleming) 2005-08-22 20:48:47

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:44:54.000-0600

Repository: asterisk
Revision: 6365

U   trunk/channels/chan_sip.c
U   trunk/configs/sip.conf.sample

r6365 | kpfleming | 2008-01-15 15:44:53 -0600 (Tue, 15 Jan 2008) | 2 lines

support configurable Message-Account value in NOTIFY messages (issue ASTERISK-4679)