Summary:ASTERISK-04673: [patch] code cleanup - chan_sip.c use of 'ast_buildstring' and wrapper for adding Content-Length to SIP replys
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2005-07-25 06:43:25Date Closed:2008-01-15 15:42:35.000-0600
Versions:Frequency of
Environment:Attachments:( 0) ast_buildstring.chan_sip.r784.txt
( 1) ast_buildstring.chan_sip.r789.txt
Description:this code cleanup uses wrapper function 'ast_buildstring' on longer sip messages.
also created wrapper function for 'Content-Length' reply.
Comments:By: Olle Johansson (oej) 2005-07-25 08:41:00

THis collides with the subscribe/presense patch which was the reason Kevin built ast_build_str. Let's keep it on hold until after that patch is included in CVS and then update it to the current state of chan_sip. Besides that, good code, thank you for contributing!

By: Frank Sautter (xylome) 2005-07-25 10:02:13

oej: this does not collide with the bug ASTERISK-3564. in fact it is one of my attempts to rip the monster patch ASTERISK-3564 apart.
i hope this is soon committed to cvs, so i can proceed with ASTERISK-3564.

By: Olle Johansson (oej) 2005-07-25 10:16:21

Well, if you go back to my patch, you see that converting the subscribe notifications to ast_build_str was one part of that patch. Leave all changes to subscribe notifications in that patch, do not move it to other patches.

By: Kevin P. Fleming (kpfleming) 2005-07-25 13:55:26

I'd rather keep the "logic of subscribe notifications" changes separate from just converting them over to ast_build_string(). If xylome is willing to split that huge patch apart into these smaller sized pieces, I'm all for that.

By: Frank Sautter (xylome) 2005-07-25 15:53:27

updated to revision 789 of chan_sip.c

By: Kevin P. Fleming (kpfleming) 2005-07-25 17:52:21

Committed to CVS HEAD with minor mod to eliminate compiler warnings... please ensure that your patches do not cause warnings in the future.


By: Digium Subversion (svnbot) 2008-01-15 15:42:35.000-0600

Repository: asterisk
Revision: 6207

U   trunk/channels/chan_sip.c

r6207 | kpfleming | 2008-01-15 15:42:35 -0600 (Tue, 15 Jan 2008) | 3 lines

add dedicated function for adding Content-Length header (bug ASTERISK-4673)
use ast_build_string to build large text bodies (bug ASTERISK-4673)