Summary:ASTERISK-04662: [patch] Bugfix: Only mention port in URI if it's not 5060
Reporter:Olle Johansson (oej)Labels:
Date Opened:2005-07-23 12:56:00Date Closed:2008-01-15 15:42:24.000-0600
Versions:Frequency of
Environment:Attachments:( 0) sipport.txt
Description:A recent patch broke chan_sip. We need to make sure that we add port number in the URI if it's not the RFC default SIP port, which is 5060. This has nothing to do with our DEFAULT_SIP_PORT, which is the SIP port for where Asterisk listens.
Comments:By: twisted (twisted) 2005-07-23 14:43:28

should we possibly change DEFAULT_SIP_PORT to SIP_BIND_PORT and actually set DEFAULT_SIP_PORT to 5060 in this case then?  This would allow someone who wants to "modify" the behaviour (such as their network expects that sip will always be on another port, say 7001, to only set the port if it's not 7001.

By: Olle Johansson (oej) 2005-07-23 14:47:28

That's really why we have the option for changing port in SIP.conf. I just wanted to make sure that even if you change DEFAULT_SIP_PORT (even if you don't have to) that the URI isn't broken.

By: Kevin P. Fleming (kpfleming) 2005-07-25 14:04:47

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:42:24.000-0600

Repository: asterisk
Revision: 6194

U   trunk/channels/chan_sip.c

r6194 | kpfleming | 2008-01-15 15:42:24 -0600 (Tue, 15 Jan 2008) | 2 lines

ensure that port number in URI is presented when needed (bug ASTERISK-4662)