[Home]

Summary:ASTERISK-04659: [patch] added Russian syntax (ast_say_number_full_ru)
Reporter:Sergey Basmanov (sb)Labels:
Date Opened:2005-07-23 10:29:48Date Closed:2008-01-15 15:45:50.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Internationalization
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say_num_ru.diff
( 1) say_ru_v2.diff
( 2) say_ru_v3.diff
( 3) say_ru.diff
( 4) say.c.diff.txt
Description:Implemented only ast_say_number_full_ru
I'll add other functions 2-3 weeks later.
This function not tested - need feedback.
Comments:By: Kevin P. Fleming (kpfleming) 2005-07-25 14:15:36

Notes:

1) Please make use of the '%' and '%=' operators, instead of coding them directly.

2) There is a small misspelling in the function comments that list the sound files required.

3) There is no need to prototype a static function unless you need to forward-reference it.

4) This will definitely need testers... please post a message to asterisk-dev and/or asterisk-users to see if you can find some speakers of Russian to test it (especially helpful would be if you have sound files recorded to go with it for testing).
By: Sergey Basmanov (sb) 2005-07-26 00:27:53

Can You please point me where misspelling? English is not my native language.

I'll implement all other functions in say.c and fix this issues a week or two later.
By: Serge Vecher (serge-v) 2005-07-26 10:32:44

1) 'two hundreds' should be 'two hundred'
2) 'thousans.gsm' should be 'thousands.gsm'

Hope this helps.
By: Igor Goncharovsky (igorg) 2005-07-27 02:25:07

I have another patch for same purpose. Main different from previos patch, that my can say number in different gender. Also, in my opinion my patch must be faster and use less memory.

I`ll try to get testers for this two patches.


By: Vyacheslav (aquar) 2005-07-29 01:51:50

I've tested only second patch...
works fine
says numbers like 839234234, 653, 232324 ok.
i'm happy =)


By: Sergey Basmanov (sb) 2005-07-30 13:59:34

I've tested my patch and found it broken :(

2IgorG: what happens with allocated memory? I haven't found any free().
By: Sergey Basmanov (sb) 2005-07-30 15:11:29

Please take a look at this patch. I've tested this path and seems that it works.
By: Sergey Basmanov (sb) 2005-07-30 16:01:21

Added gender. Additional files:
1X.gsm,2X.gsm, where X in f,m,n (or anything else :)
By: Igor Goncharovsky (igorg) 2005-08-01 05:17:43

Yes, no free() in my patch. Actualy, at begin I have copyed part of code from Polish say() realization. Memory get at first call of function, pointer saved in static variable and will be free on program exit by OS.

Now it is no nececary and I clean code frome this, tommorow i want to place a new patch with part realization of russian date support.
By: Sergey Basmanov (sb) 2005-08-16 01:05:54

IgroG, if You are not working on this issue anymore, please let me know. I think there is no need to have two different implementations of one thing.
By: Sergey Basmanov (sb) 2005-08-16 03:59:51

Changed processing of numbers more than 999.
I've tested this patch on my system and seems that it works as expected.
Please let me know if there any mistakes.
By: Kevin P. Fleming (kpfleming) 2005-08-26 16:27:54

Committed to CVS HEAD, thanks to both of you!
By: Digium Subversion (svnbot) 2008-01-15 15:45:50.000-0600

Repository: asterisk
Revision: 6428

U   trunk/say.c

------------------------------------------------------------------------
r6428 | kpfleming | 2008-01-15 15:45:49 -0600 (Tue, 15 Jan 2008) | 2 lines

add Russian support to say_number (issue ASTERISK-4659)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6428