[Home]

Summary:ASTERISK-04654: include file in addons perl scripts
Reporter:Dan Mahoney (gushi)Labels:
Date Opened:2005-07-22 07:29:44Date Closed:2011-06-07 14:10:33
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:For the asterisk_addons packages, would it be possible to have the get_x_from_mysql.pl scripts require a common include file, so that if I have asterisk running in a different place (other than /etc/asterisk, I'm running multiple), I can simply update that file, rather than modifying all the perl scripts?

Alternatively, if the files could be tweaked to read the -C argument as asterisk does (also trivial) that would work.

I could supply patches for this (either), easily (we're talking changes of one or two lines of code), and if this is not added I'll have to write the patches internally anyway.
Comments:By: Olle Johansson (oej) 2005-07-22 07:46:46

With realtime, I think those scripts should be removed in CVS head, really.

By: Olle Johansson (oej) 2005-07-22 07:50:28

If you want to upload patches, then please make sure that all scripts are up to date with current cvs head. I don't think anyone has looked into them for some time since the rest of the world is heading for realtime.

By: Dan Mahoney (gushi) 2005-07-22 08:04:09

True, but things like AMP still use them (and that's my principal reason for using them...although AMP requests you checkout 1-0, so those changes might not make it in there, not sure of commit process...)

Anyway, when you say "up to date with current CVS head" do you mean make sure I generate a patch against those, or make sure those scripts comply with the same version/schema of the DB that e.g. realtime use?

By: Olle Johansson (oej) 2005-07-22 08:27:01

We do not really change anything in the released version, so if you want to change the scripts, it's the CVS head that is the platform you should use.

By: Brian West (bkw918) 2005-07-25 21:08:06

I don't think we should worry with this.  1.2 is in the pipes.

/b