Summary:ASTERISK-04640: [patch] Formatting, small code change
Reporter:Olle Johansson (oej)Labels:
Date Opened:2005-07-20 15:45:38Date Closed:2011-06-07 14:10:50
Versions:Frequency of
Environment:Attachments:( 0) voicemail0720.txt
Description:This patch changes code format of app_voicemail, adds some comments and makes one small code change in order to remove one extra check across my hard disk drive for new and old messages.

Needs testing.


disclaimer on file.
Comments:By: Kevin P. Fleming (kpfleming) 2005-07-20 18:53:06

It looks good to me, although I agree that it needs testers. A couple of notes:

- you changed from using ast_goto_if_exists() to the old method.

- I think this would be right time to introduce the VMSTATUS result variable and some option flag to stop Voicemail() from jumping a new priority (use 'j' like Dial() uses). However, maybe that should be a separate patch so it goes in as a separate commit... I'll leave that to your discretion.

By: Olle Johansson (oej) 2005-07-21 01:24:08

The VMSTATUS, yes, I think that's a separate patch. We also need ENUMSTATUS for Enumlookup and maybe others to clean that up.

The other change was a mistake, that's why I said "Need testing"... A lot of code was moved around.

By: Kevin P. Fleming (kpfleming) 2005-08-22 15:55:31

What is the status of this patch? It's been idle for a few weeks now, so we either need to suspend it or update it and get it into 1.2.

By: Kevin P. Fleming (kpfleming) 2005-08-26 19:07:52

Due to many other patches being applied to app_voicemail, this one has no chance of still applying properly. Let's get a new patch for the code change separate from the formatting cleanup, and leave the formatting changes for after 1.2 or when we are close to final release and no other patches are going in.