[Home]

Summary:ASTERISK-04632: [patch] Formatting astmm.c
Reporter:Paul Belanger (pabelanger)Labels:
Date Opened:2005-07-19 21:39:47Date Closed:2008-01-15 15:43:32.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) astmm.c.patch
( 1) astmm.c.patch-v2
Description:Clean up some code, and remove hardcoded path (/var/log/asterisk/mmlog)
Comments:By: Russell Bryant (russell) 2005-07-21 00:02:41

You didn't even try to compile it!  :-p

+ char filename[80] = ""

And, while we're at it, could you add the opening paren back in this message?

- ast_verbose("Asterisk Malloc Debugger Started (see /var/log/asterisk/mmlog)\n");
+ ast_verbose("Asterisk Malloc Debugger Started see %s)\n", filename);
By: Russell Bryant (russell) 2005-07-21 00:04:33

more problems ...

+
+ snprintf(filename, sizeof(filename), "%s/mmlog", (char *)ast_config_AST_LOG_DIR)

And, you need to inclue "asterisk/utils.h" so that ast_copy_string will be defined
By: Russell Bryant (russell) 2005-07-21 00:52:03

Actually, the missing utils.h thing is my fault.  Sorry!  But if you don't mind including that in your updated patch, I would appreciate it.  :-)
By: Paul Belanger (pabelanger) 2005-07-26 00:59:18

Sorry for the delay on this one.  I'll get you a new patch today.
By: Paul Belanger (pabelanger) 2005-07-26 12:41:27

Compiled, tested and patched. ;)
By: Mark Spencer (markster) 2005-08-03 00:45:55

Fixed in CVS head.  Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:43:32.000-0600

Repository: asterisk
Revision: 6269

U   trunk/astmm.c

------------------------------------------------------------------------
r6269 | markster | 2008-01-15 15:43:31 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix some astmm formatting and path issues (bug ASTERISK-4632)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6269