| Summary: | ASTERISK-04605: [patch] Manager action "DBGet" does not send ActionID back and is missing locking | ||
| Reporter: | Stefan Reuter (srt) | Labels: | |
| Date Opened: | 2005-07-16 08:50:22 | Date Closed: | 2008-01-15 15:42:05.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) db.patch | |
| Description: | The patch includes the ActionID in the DBGetResponse event and adds proper locking of the manager session. | ||
| Comments: | By: Olle Johansson (oej) 2005-07-18 06:14:06 Seems like a good patch to me. By: Kevin P. Fleming (kpfleming) 2005-07-19 20:31:38 Committed to CVS HEAD, thanks! This series of patches has been a nice thing, but I think it might be wise at this point to create a function to do the ActionID handling for a manager action, as opposed to repeating that code in every single action handler function. By: Stefan Reuter (srt) 2005-07-19 21:30:55 sorry to reopen this issue, but that seems best to get hold on you ;) your suggestion would probably include adding two new functions: - astman_send_action_event - astman_send_action_complete_event that are modeled like astman_send_response. right? should i submit a patch for that? By: Kevin P. Fleming (kpfleming) 2005-07-25 18:35:35 Please discuss potential ways to clean this up on the asterisk-dev mailing list, not in a bug that has already been resolved. By: Digium Subversion (svnbot) 2008-01-15 15:42:05.000-0600 Repository: asterisk Revision: 6175 U trunk/db.c ------------------------------------------------------------------------ r6175 | kpfleming | 2008-01-15 15:42:04 -0600 (Tue, 15 Jan 2008) | 2 lines add ActionID output and lock CLI fd for Manager action DBGet (bug ASTERISK-4605) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6175 | ||