[Home]

Summary:ASTERISK-04601: [patch] Manager action "Agents" does not send ActionID back, does not send an ACK and is missing an AgentsCompleteEvent
Reporter:Stefan Reuter (srt)Labels:
Date Opened:2005-07-15 10:28:58Date Closed:2008-01-15 15:41:34.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_agent
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_agent.patch
Description:The patch includes the ActionID in the Actions events generated and sends an ACK before sending the events.
It also sends an Event: AgentsComplete to indicate that all Agents have been reported. (like the Status action is manager.c)

****** ADDITIONAL INFORMATION ******

Not quite sure if the locking on the manager session is done the right way.
Comments:By: Stefan Reuter (srt) 2005-07-15 10:39:22

not sending a response when receiving an action via Manager API is a protocol violation => bug IMHO at least ;)

By: Kevin P. Fleming (kpfleming) 2005-07-15 12:14:15

Committed to CVS HEAD with a minor mod to use sizeof() instead of hardcoding the size of the text buffer. Thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:41:34.000-0600

Repository: asterisk
Revision: 6141

U   trunk/channels/chan_agent.c

------------------------------------------------------------------------
r6141 | kpfleming | 2008-01-15 15:41:34 -0600 (Tue, 15 Jan 2008) | 2 lines

make 'Agents' manager action conform to protocol (bug ASTERISK-4601)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6141